Skip to content

Commit ff088ea

Browse files
committed
docs: Improve Menu selection group story
1 parent 71f0ef2 commit ff088ea

File tree

1 file changed

+55
-14
lines changed

1 file changed

+55
-14
lines changed

packages/@react-spectrum/s2/stories/Menu.stories.tsx

+55-14
Original file line numberDiff line numberDiff line change
@@ -10,20 +10,29 @@
1010
* governing permissions and limitations under the License.
1111
*/
1212

13+
import AlignLeft from '../s2wf-icons/S2_Icon_TextAlignLeft_20_N.svg';
14+
import AlignMiddle from '../s2wf-icons/S2_Icon_TextAlignCenter_20_N.svg';
15+
import AlignRight from '../s2wf-icons/S2_Icon_TextAlignRight_20_N.svg';
16+
import Bold from '../s2wf-icons/S2_Icon_TextBold_20_N.svg';
1317
import {Button, Header, Heading, Image, Keyboard, Menu, MenuItem, MenuSection, MenuTrigger, SubmenuTrigger, Text} from '../src';
1418
import {categorizeArgTypes} from './utils';
1519
import ClockPendingIcon from '../s2wf-icons/S2_Icon_ClockPending_20_N.svg';
1620
import {CombinedMenu} from '../src/Menu';
1721
import CommentTextIcon from '../s2wf-icons/S2_Icon_CommentText_20_N.svg';
1822
import CommunityIcon from '../s2wf-icons/S2_Icon_Community_20_N.svg';
19-
import CopyIcon from '../s2wf-icons/S2_Icon_Copy_20_N.svg';
23+
import Copy from '../s2wf-icons/S2_Icon_Copy_20_N.svg';
24+
import Cut from '../s2wf-icons/S2_Icon_Cut_20_N.svg';
2025
import DeviceDesktopIcon from '../s2wf-icons/S2_Icon_DeviceDesktop_20_N.svg';
2126
import DeviceTabletIcon from '../s2wf-icons/S2_Icon_DeviceTablet_20_N.svg';
2227
import ImgIcon from '../s2wf-icons/S2_Icon_Image_20_N.svg';
28+
import Italic from '../s2wf-icons/S2_Icon_TextItalic_20_N.svg';
2329
import type {Meta, StoryObj} from '@storybook/react';
2430
import More from '../s2wf-icons/S2_Icon_More_20_N.svg';
2531
import NewIcon from '../s2wf-icons/S2_Icon_New_20_N.svg';
32+
import Paste from '../s2wf-icons/S2_Icon_Paste_20_N.svg';
2633
import {Selection} from 'react-aria-components';
34+
import TextIcon from '../s2wf-icons/S2_Icon_Text_20_N.svg';
35+
import Underline from '../s2wf-icons/S2_Icon_TextUnderline_20_N.svg';
2736
import {useState} from 'react';
2837

2938
const meta: Meta<typeof CombinedMenu> = {
@@ -177,7 +186,7 @@ export const PublishAndExport: Story = {
177186
</MenuItem>
178187
<SubmenuTrigger>
179188
<MenuItem id="open-in" textValue="open a copy">
180-
<CopyIcon />
189+
<Copy />
181190
<Text slot="label">Open a copy</Text>
182191
<Text slot="description">Illustrator for iPad or desktop</Text>
183192
</MenuItem>
@@ -482,32 +491,64 @@ export const SelectionGroups = (args) => {
482491
let [group2, setGroup2] = useState<Selection>(new Set());
483492
return (
484493
<MenuTrigger {...triggerProps}>
485-
<Button aria-label="Actions for selected resource"><NewIcon /></Button>
494+
<Button aria-label="Text actions"><TextIcon /></Button>
486495
<Menu {...menuProps}>
487496
<MenuSection>
488497
<Header>
489-
<Heading>Actions</Heading>
498+
<Heading>Clipboard</Heading>
490499
</Header>
491-
<MenuItem>Action 1</MenuItem>
492-
<MenuItem>Action 2</MenuItem>
500+
<MenuItem>
501+
<Cut />
502+
<Text slot="label">Cut</Text>
503+
</MenuItem>
504+
<MenuItem>
505+
<Copy />
506+
<Text slot="label">Copy</Text>
507+
</MenuItem>
508+
<MenuItem>
509+
<Paste />
510+
<Text slot="label">Paste</Text>
511+
</MenuItem>
493512
</MenuSection>
494513
<MenuSection selectionMode="single" selectedKeys={group1} onSelectionChange={setGroup1}>
495514
<Header>
496-
<Heading>Single-select</Heading>
515+
<Heading>Text Alignment</Heading>
497516
</Header>
498-
<MenuItem id={1}>One</MenuItem>
499-
<MenuItem id={2}>Two</MenuItem>
500-
<MenuItem id={3}>Three</MenuItem>
517+
<MenuItem id={1}>
518+
<AlignLeft />
519+
<Text slot="label">Left</Text>
520+
</MenuItem>
521+
<MenuItem id={2}>
522+
<AlignMiddle />
523+
<Text slot="label">Center</Text>
524+
</MenuItem>
525+
<MenuItem id={3}>
526+
<AlignRight />
527+
<Text slot="label">Right</Text>
528+
</MenuItem>
501529
</MenuSection>
502530
<MenuSection selectionMode="multiple" selectedKeys={group2} onSelectionChange={setGroup2}>
503531
<Header>
504-
<Heading>Multi-select</Heading>
532+
<Heading>Font Style</Heading>
505533
</Header>
506-
<MenuItem id={4}>Four</MenuItem>
507-
<MenuItem id={5}>Five</MenuItem>
508-
<MenuItem id={6}>Siz</MenuItem>
534+
<MenuItem id={4}>
535+
<Bold />
536+
<Text slot="label">Bold</Text>
537+
</MenuItem>
538+
<MenuItem id={5}>
539+
<Italic />
540+
<Text slot="label">Italic</Text>
541+
</MenuItem>
542+
<MenuItem id={6}>
543+
<Underline />
544+
<Text slot="label">Underline</Text>
545+
</MenuItem>
509546
</MenuSection>
510547
</Menu>
511548
</MenuTrigger>
512549
);
513550
};
551+
552+
SelectionGroups.parameters = {
553+
layout: 'padded'
554+
};

0 commit comments

Comments
 (0)