Tooltip shouldn't appear on restoreFocus from FocusScope

[snowystinger]

🐛 Bug Report

This came from a tweet:
https://twitter.com/jjenzz/status/1317190750120062982
A good one is Tooltip, where refocusing a menu button after the menu closes should not reactivate its tooltip. Here's a comparison between React tree approach and React Aria (use keyboard to focus and space bar to open/close)
https://t.co/ZBgex6HZOx?amp=1

Tooltip also shouldn't block the menu from opening from Spacebar:
I also noticed that the tooltip was preventing space bar from working on my menu button so I had to avoid forwarding onKeyDown events from react-aria

🤔 Expected Behavior

The tooltip should not appear when the menu closes.

😯 Current Behavior

💁 Possible Solution

🔦 Context

💻 Code Sample

🌍 Your Environment

Software	Version(s)
react-spectrum
Browser
Operating System

🧢 Your Company/Team

🕷 Tracking Issue (optional)

[Andarist]

Any thoughts on the implementation of this? If I could get some direction in which u’d like to go with it I could maybe take a stab on this one

[snowystinger]

Maybe originalEvent? I believe element.focus() event won't have that property. This would allow us to tell if the element received focus programmatically or from a user interaction. I'm trying to think if there are any cases where we wouldn't want to ignore programmatic focus for a tooltip

[paulchan14]

I would like to give this issue a try.

[paulchan14]

@snowystinger, is this issue only related to FocusScope? I'm reproducing the tooltip triggering after closing a menu without the FocusScope at all. Would this be better fixed under the scope of Tooltip?

[snowystinger]

I do not recall much of this unfortunately. However, it looks like the codesandbox in the description does not have any FocusScope in it. So yeah, this is probably something to fix in the Tooltip code.

[paulchan14]

Thanks, I just wanted to make sure I wasn't missing anything since FocusScope was in the issue description. I'll keep working it