-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: Form to use addPerson function to show usage of useTreeData #6503
Conversation
You'll need to sign the CLA https://react-spectrum.adobe.com/contribute.html#contributor-license-agreement then close and reopen the PR to get it to take The tests are failing because main hasn't been merged in, so I've done that for you. |
|
GET_BUILD |
</TextField> | ||
<Button type="submit">Submit</Button> | ||
</Form> | ||
</> | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate wanting to make this example more complete, but I think we need to be careful not to overwhelm the reader with stuff that isn't super relevant. The point of the example it to show useTreeData
, not ListBox
, or Form
, or TextField
, etc. It mirrors the above example for useListData
. For more details on using the methods, we have a link to the useTreeData
docs. This page is just an overview so I think it's ok to not show everything in detail. So I think either we remove the addPerson
function if people think it's confusing and leave the documentation of that to the useTreeData
docs, or just leave it since it shows the general usage.
8cb1a5d
to
3013156
Compare
Closing, if you're still interested in making this change, we can reopen it. Thanks! |
Closes #6250
Added usage of addPerson function in collection's useTreeData example
✅ Pull Request Checklist: