Skip to content

Circular dependency warnings when building #6394

Open
@gunnx

Description

@gunnx

Provide a general summary of the issue here

When building our application we get warnings from packages used by React Aria:

🤔 Expected Behavior?

No errors during build

😯 Current Behavior

Errors shown :

Circular dependency: node_modules/@internationalized/date/dist/CalendarDate.mjs -> node_modules/@internationalized/date/dist/manipulation.mjs -> node_modules/@internationalized/date/dist/conversion.mjs -> node_modules/@internationalized/date/dist/CalendarDate.mjs Circular dependency: node_modules/@internationalized/date/dist/manipulation.mjs -> node_modules/@internationalized/date/dist/conversion.mjs -> node_modules/@internationalized/date/dist/manipulation.mjs Circular dependency: node_modules/@internationalized/date/dist/CalendarDate.mjs -> node_modules/@internationalized/date/dist/manipulation.mjs -> node_modules/@internationalized/date/dist/conversion.mjs -> node_modules/@internationalized/date/dist/GregorianCalendar.mjs -> node_modules/@internationalized/date/dist/CalendarDate.mjs Circular dependency: node_modules/@internationalized/date/dist/CalendarDate.mjs -> node_modules/@internationalized/date/dist/manipulation.mjs -> node_modules/@internationalized/date/dist/conversion.mjs -> node_modules/@internationalized/date/dist/GregorianCalendar.mjs -> node_modules/@internationalized/date/dist/utils.mjs -> node_modules/@internationalized/date/dist/CalendarDate.mjs Circular dependency: node_modules/@internationalized/date/dist/conversion.mjs -> node_modules/@internationalized/date/dist/queries.mjs -> node_modules/@internationalized/date/dist/conversion.mjs Circular dependency: node_modules/@internationalized/date/dist/CalendarDate.mjs -> node_modules/@internationalized/date/dist/string.mjs -> node_modules/@internationalized/date/dist/CalendarDate.mjs Circular dependency: node_modules/react-aria-components/dist/Dialog.mjs -> node_modules/react-aria-components/dist/Popover.mjs -> node_modules/react-aria-components/dist/Dialog.mjs

💁 Possible Solution

Shared functions or types might require to be moved out to be imported separately or import paths changed

🔦 Context

No response

🖥️ Steps to Reproduce

Install react-aria-components 1.2.0

import { Button as AriaButton, DateInput as AriaDateInput, DatePicker as AriaDatePicker, DateSegment as AriaDateSegment, Dialog as AriaDialog, Group as AriaGroup, Popover as AriaPopover, DateValue } from 'react-aria-components';

run a build , we use rollup and errors are showing during the bundling

Version

[email protected]

What browsers are you seeing the problem on?

Firefox

If other, please specify.

No response

What operating system are you using?

Mac

🧢 Your Company/Team

No response

🕷 Tracking Issue

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions