-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CommonJS build and add Jest setup to test app #6410
Conversation
This reverts commit b4d69f0.
Verdaccio builds: CRA Test App The test also ran in this CircleCI run: https://app.circleci.com/pipelines/github/adobe/react-spectrum/20292/workflows/753efde2-72df-497d-9a91-c90523140ec7/jobs/301441 (search for "smoke") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM did a quick sweep of the verdaccio apps, lets get this tested some more on monday
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noticed some weird behavior in the RAC Tailwind Example app with the popover and combobox. when you select an item in the popover, it scrolls the page up and then you have to click on the page to scroll the page again. with the combobox, there's just some weird animation when you open the combobox. otherwise, didn't notice anything weird in the other test apps
@yihuiliao could you check if these also happen on main? |
yep, just checked on main and seems like it also happens there so unrelated to the changes in this PR |
Pulls in parcel-bundler/parcel#9722 to fix the CommonJS build. Also adds a Jest test setup to one of our example apps that renders many components to verify they work in that environment. This will run in our verdaccio CI script. I verified that the test failed using the old build and should now pass.