Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Hue Normalization #6456

Merged
merged 7 commits into from
May 30, 2024
Merged

Fix: Hue Normalization #6456

merged 7 commits into from
May 30, 2024

Conversation

theMosaad
Copy link
Contributor

Closes #6202

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

snowystinger

This comment was marked as duplicate.

@snowystinger
Copy link
Member

GET_BUILD

@rspbot
Copy link

rspbot commented May 28, 2024

Copy link
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried out the ColorWheel, I can get it to fire onChange with both 0 and 360. This seems poor as it could result in an extra/ambiguous render.

Should the color wheel be unambiguous and only fire 0-359? but parsing can handle the 0-360 range?

Screenshot 2024-05-28 at 11 57 19 AM

@theMosaad theMosaad requested a review from snowystinger May 28, 2024 07:58
@yihuiliao

This comment was marked as duplicate.

2 similar comments
@yihuiliao

This comment was marked as duplicate.

@snowystinger
Copy link
Member

GET_BUILD

@rspbot
Copy link

rspbot commented May 28, 2024

@rspbot
Copy link

rspbot commented May 28, 2024

## API Changes

unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }

@ktabors
Copy link
Member

ktabors commented May 29, 2024

Tried out the ColorWheel, I can get it to fire onChange with both 0 and 360. This seems poor as it could result in an extra/ambiguous render.

I found that getting the 360 value for hue in an onChange is pre-existing. No change needed.
image

@yihuiliao yihuiliao merged commit 1cacbf1 into adobe:main May 30, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parseColor converts hue from 360 to 0
5 participants