Skip to content

Modal & ModalOverlay onOpenChange don't fire #6547

Open
@ArrayKnight

Description

@ArrayKnight

Provide a general summary of the issue here

When implementing a dialog, there are three possible spots to implement the callback onOpenChange, on the DialogTrigger, ModalOverlay (if present), and the Modal. But only the one on the DialogTrigger ever fires

🤔 Expected Behavior?

All onOpenChange callbacks can be utilized and will be called

😯 Current Behavior

ModalOverlay and Modal's implementations of onOpenChange never get called

💁 Possible Solution

No response

🔦 Context

No response

🖥️ Steps to Reproduce

https://codesandbox.io/p/sandbox/nifty-buck-jmkkl7

Version

1.2.1

What browsers are you seeing the problem on?

Chrome

If other, please specify.

No response

What operating system are you using?

Mac & Windows

🧢 Your Company/Team

No response

🕷 Tracking Issue

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentation

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions