Skip to content

Commit 09e59be

Browse files
committed
Handle the case when undefined is sent as a paramter to the logger.
1 parent 88ec984 commit 09e59be

File tree

3 files changed

+19
-3
lines changed

3 files changed

+19
-3
lines changed

.eslintrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"parserOptions": {
3-
"ecmaVersion": 2018
3+
"ecmaVersion": 2020
44
},
55
"extends": [
66
"airbnb-base",

src/__tests__/createNewLogger.test.js

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@ describe('createNewLogger', () => {
2424
logger.debug('another log', 5, 4);
2525
logger.warn('yet another log', true);
2626
logger.error('and one error');
27+
logger.error([1, 2, 3, undefined]);
28+
logger.log('Output', undefined);
2729

2830
// Get all JSON logs.
2931
expect(logger.getJsonLogs()).toStrictEqual([
@@ -61,11 +63,25 @@ describe('createNewLogger', () => {
6163
messages: ['🚀', 'and one error'],
6264
name: 'evaluatingRule',
6365
timestampMs: 1111
66+
},
67+
{
68+
attributes: { logLevel: 'error' },
69+
context: { ruleId: 1234 },
70+
messages: ['🚀', '[1,2,3,null]'],
71+
name: 'evaluatingRule',
72+
timestampMs: 1111
73+
},
74+
{
75+
attributes: { logLevel: 'log' },
76+
context: { ruleId: 1234 },
77+
messages: ['🚀', 'Output', undefined],
78+
name: 'evaluatingRule',
79+
timestampMs: 1111
6480
}
6581
]);
6682
});
6783

68-
test.only('returns an object which allows anonymizing tokens in logs', () => {
84+
test('returns an object which allows anonymizing tokens in logs', () => {
6985
const context = { ruleId: 1234 };
7086
const logger = createNewLogger(context, [
7187
'TOKENIZED_DATA',

src/createNewLogger.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ const process = (logLevel, context, logsBucket, logSensitiveTokens, args) => {
5757
attributes: { logLevel },
5858
messages: args.map((m) =>
5959
typeof m !== 'string'
60-
? JSON.stringify(m).replaceAll(sensitiveTokensRegexp, anonymizeString)
60+
? JSON.stringify(m)?.replaceAll(sensitiveTokensRegexp, anonymizeString)
6161
: m.replaceAll(sensitiveTokensRegexp, anonymizeString)
6262
),
6363
context

0 commit comments

Comments
 (0)