Skip to content

Commit 33ae1ac

Browse files
authored
Merge pull request #5 from adobe/remove_fake_logger
Remove fake logger.
2 parents b697110 + 49a8e5b commit 33ae1ac

File tree

5 files changed

+3
-58
lines changed

5 files changed

+3
-58
lines changed

src/__tests__/createModuleProvider.test.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -76,10 +76,7 @@ describe('createModuleProvider', () => {
7676
'anotherExtension/src/lib/dataElements/path.js'
7777
);
7878
}).toThrowError(
79-
new Error(
80-
'Failed to access module "anotherExtension/src/lib/dataElements/path.js". ' +
81-
"Cannot read property 'script' of undefined"
82-
)
79+
/Failed to access module "anotherExtension\/src\/lib\/dataElements\/path\.js"/
8380
);
8481
});
8582

src/__tests__/getFakeLogger.test.js

Lines changed: 0 additions & 26 deletions
This file was deleted.

src/__tests__/index.test.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ describe('index', () => {
3636
});
3737

3838
return execute(callData, {
39-
isDebugEnabled: true,
4039
headersForSubrequests: {}
4140
}).then((result) => {
4241
expect(result).toStrictEqual([

src/executeRules.js

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ governing permissions and limitations under the License.
1010
*/
1111

1212
const createNewLogger = require('./createNewLogger');
13-
const fakeLogger = require('./getFakeLogger');
1413

1514
const getRuleFetchFn = require('./getRuleFetchFn');
1615
const checkConditionResult = require('./rules/checkConditionResult');
@@ -25,7 +24,7 @@ module.exports = (
2524
container,
2625
globalFetch,
2726
callData,
28-
{ isDebugEnabled, headersForSubrequests } = {}
27+
{ headersForSubrequests } = {}
2928
) => {
3029
const rulePromises = [];
3130

@@ -36,9 +35,7 @@ module.exports = (
3635
rules.forEach((rule) => {
3736
const { id, name } = rule;
3837

39-
const logger = isDebugEnabled
40-
? createNewLogger({ ruleId: rule.id })
41-
: fakeLogger;
38+
const logger = createNewLogger({ ruleId: rule.id });
4239

4340
const fetch = getRuleFetchFn(globalFetch, headersForSubrequests, logger);
4441

src/getFakeLogger.js

Lines changed: 0 additions & 22 deletions
This file was deleted.

0 commit comments

Comments
 (0)