Skip to content

Commit 6387a44

Browse files
nickschaapNick Schaap
andauthored
feat: more detailed gitops pr commit msg (#202)
Co-authored-by: Nick Schaap <schaap@adobe.com>
1 parent 7232c63 commit 6387a44

3 files changed

Lines changed: 13 additions & 5 deletions

File tree

gitops/commitmsg/commitmsg.go

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,16 @@ func ExtractTargets(msg string) (packages []string) {
4040
return
4141
}
4242

43-
// Generate generates a commit message from a list of targets
44-
func Generate(targets []string) string {
43+
// Generate generates a commit message from a list of targets, including git branch and commit info above the targets block
44+
func Generate(targets []string, branchName, gitCommit string) string {
4545
var sb strings.Builder
4646
sb.WriteByte('\n')
47+
sb.WriteString("Branch: ")
48+
sb.WriteString(branchName)
49+
sb.WriteByte('\n')
50+
sb.WriteString("Commit: ")
51+
sb.WriteString(gitCommit)
52+
sb.WriteByte('\n')
4753
sb.WriteString(begin)
4854
sb.WriteByte('\n')
4955

gitops/commitmsg/commitmsg_test.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ import (
2121

2222
func TestRoundtrip(t *testing.T) {
2323
targets := []string{"target1", "target2"}
24-
msg := commitmsg.Generate(targets)
24+
msg := commitmsg.Generate(targets, "my-branch", "abc123")
2525
t2 := commitmsg.ExtractTargets(msg)
2626
if !reflect.DeepEqual(targets, t2) {
2727
t.Errorf("Unexpected targets after parsing: %v", t2)
@@ -30,9 +30,11 @@ func TestRoundtrip(t *testing.T) {
3030

3131
func ExampleGenerate() {
3232
targets := []string{"target1", "target2"}
33-
msg := commitmsg.Generate(targets)
33+
msg := commitmsg.Generate(targets, "my-branch", "abc123")
3434
fmt.Println(msg)
3535
// Output:
36+
// Branch: my-branch
37+
// Commit: abc123
3638
// --- gitops targets begin ---
3739
// target1
3840
// target2

gitops/prer/create_gitops_prs.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ func main() {
211211
}
212212
}
213213
}
214-
if workdir.Commit(fmt.Sprintf("GitOps for release branch %s from %s commit %s\n%s", *releaseBranch, *branchName, *gitCommit, commitmsg.Generate(targets)), *gitopsPath) {
214+
if workdir.Commit(fmt.Sprintf("GitOps for release branch %s from %s commit %s\n%s", *releaseBranch, *branchName, *gitCommit, commitmsg.Generate(targets, *branchName, *gitCommit)), *gitopsPath) {
215215
log.Println("branch", branch, "has changes, push is required")
216216
updatedGitopsBranches = append(updatedGitopsBranches, branch)
217217
}

0 commit comments

Comments
 (0)