Skip to content

Commit 159348d

Browse files
committed
chore: test coverage for normalized URLs
1 parent b250bc4 commit 159348d

File tree

1 file changed

+10
-9
lines changed

1 file changed

+10
-9
lines changed

test/facets.test.js

+10-9
Original file line numberDiff line numberDiff line change
@@ -212,13 +212,13 @@ describe('facets:acquisitionSource', () => {
212212

213213
describe('facets:enterSource', () => {
214214
it('enterSource:bare', () => {
215-
assert.deepEqual(facets.enterSource({ events: [{ checkpoint: 'enter', source: 'https://www.example.com' }] }), ['https://www.example.com']);
216-
assert.deepEqual(facets.enterSource({ events: [{ checkpoint: 'enter', source: 'https://www.google.com' }] }), ['https://www.google.com', 'search:google', 'search', '*:google']);
215+
assert.deepEqual(facets.enterSource({ events: [{ checkpoint: 'enter', source: 'https://www.example.com/' }] }), ['https://www.example.com/']);
216+
assert.deepEqual(facets.enterSource({ events: [{ checkpoint: 'enter', source: 'https://www.google.com/' }] }), ['https://www.google.com/', 'search:google', 'search', '*:google']);
217217
});
218218

219219
it('enterSource:normalizeUrl', () => {
220-
assert.deepEqual(facets.enterSource({ events: [{ checkpoint: 'enter', source: 'https://www.example.com/#' }] }), ['https://www.example.com']);
221-
assert.deepEqual(facets.enterSource({ events: [{ checkpoint: 'enter', source: 'https://www.google.com/#' }] }), ['https://www.google.com', 'search:google', 'search', '*:google']);
220+
assert.deepEqual(facets.enterSource({ events: [{ checkpoint: 'enter', source: 'https://www.example.com/#' }] }), ['https://www.example.com/']);
221+
assert.deepEqual(facets.enterSource({ events: [{ checkpoint: 'enter', source: 'https://www.google.com/#' }] }), ['https://www.google.com/', 'search:google', 'search', '*:google']);
222222
});
223223

224224
it('enterSource:DataChunks', () => {
@@ -227,11 +227,12 @@ describe('facets:enterSource', () => {
227227
d.addSeries('pageViews', pageViews);
228228
d.addFacet('enterSource', facets.enterSource);
229229

230-
assert.equal(d.facets.enterSource.length, 46);
231-
assert.equal(d.facets.enterSource[2].value, 'search'); // all search engines
232-
assert.equal(d.facets.enterSource[3].value, 'search:google'); // google search
233-
assert.equal(d.facets.enterSource[4].value, '*:google'); // all google properties
234-
assert.equal(d.facets.enterSource[5].value, 'https://www.google.com/'); // that one specific google page
230+
assert.equal(d.facets.enterSource.length, 44);
231+
232+
assert.equal(d.facets.enterSource[0].value, 'search'); // all search engines
233+
assert.equal(d.facets.enterSource[1].value, 'search:google'); // google search
234+
assert.equal(d.facets.enterSource[2].value, '*:google'); // all google properties
235+
assert.equal(d.facets.enterSource[3].value, 'https://www.google.com/'); // that one specific google page
235236
});
236237
});
237238

0 commit comments

Comments
 (0)