Merge pull request #32 from adobe/issue-31

feat: normalise # in URLs for referrer classification

Author: asthabh23

facets.js

@@ -158,6 +158,7 @@ export const facets = {
     .filter((evt) => evt.checkpoint === 'enter')
     .map((evt) => evt.source)
     .filter((source) => source)
+    .map((source) => source.replace(/\/#$/, ''))
     .map((source) => {
       const referrerClass = classifyReferrer(source);
       return referrerClass ? [
@@ -192,7 +193,7 @@ export const facets = {
       }
       return u.toString();
     }),
-};
+  };
 
 /**
  * A facet function takes a bundle and returns an array of facet values.

test/facets.test.js

@@ -216,6 +216,11 @@ describe('facets:enterSource', () => {
     assert.deepEqual(facets.enterSource({ events: [{ checkpoint: 'enter', source: 'https://www.google.com' }] }), ['https://www.google.com', 'search:google', 'search', '*:google']);
   });
 
+  it('enterSource:normalizeUrl', () => {
+    assert.deepEqual(facets.enterSource({ events: [{ checkpoint: 'enter', source: 'https://www.example.com/#' }] }), ['https://www.example.com']);
+    assert.deepEqual(facets.enterSource({ events: [{ checkpoint: 'enter', source: 'https://www.google.com/#' }] }), ['https://www.google.com', 'search:google', 'search', '*:google']);
+  });
+
   it('enterSource:DataChunks', () => {
     const d = new DataChunks();
     d.load(testChunks);