Skip to content

Commit 83ad0bd

Browse files
committed
feat(colorwheel): s2 migration
1 parent e3585cd commit 83ad0bd

File tree

3 files changed

+38
-20
lines changed

3 files changed

+38
-20
lines changed

.changeset/giant-windows-smoke.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
"@spectrum-css/colorwheel": major
3+
---
4+
5+
# colorwheel S2 migration
6+
7+
This change migrates the colorwheel component to S2. It adds the `--spectrum-colorwheel-border-color-rgb` and `--spectrum-colorwheel-border-opacity` custom properties. It updates `--spectrum-colorwheel-border-color` to leverage these tokens in an `rgba(...)` function.

components/colorwheel/dist/metadata.json

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,26 +19,27 @@
1919
],
2020
"modifiers": [
2121
"--mod-colorwheel-border-color",
22-
"--mod-colorwheel-border-width",
2322
"--mod-colorwheel-colorarea-container-size",
2423
"--mod-colorwheel-colorarea-margin",
2524
"--mod-colorwheel-fill-color-disabled",
26-
"--mod-colorwheel-height",
2725
"--mod-colorwheel-min-width",
2826
"--mod-colorwheel-path",
2927
"--mod-colorwheel-path-borders",
30-
"--mod-colorwheel-track-width",
31-
"--mod-colorwheel-width"
28+
"--mod-colorwheel-track-width"
3229
],
3330
"component": [
3431
"--spectrum-color-wheel-color-area-margin",
3532
"--spectrum-color-wheel-minimum-width",
3633
"--spectrum-color-wheel-width",
3734
"--spectrum-colorwheel-border-color",
35+
"--spectrum-colorwheel-border-color-rgb",
36+
"--spectrum-colorwheel-border-opacity",
3837
"--spectrum-colorwheel-border-width",
3938
"--spectrum-colorwheel-colorarea-container-size",
39+
"--spectrum-colorwheel-colorarea-margin",
4040
"--spectrum-colorwheel-fill-color-disabled",
4141
"--spectrum-colorwheel-height",
42+
"--spectrum-colorwheel-min-width",
4243
"--spectrum-colorwheel-path",
4344
"--spectrum-colorwheel-path-borders",
4445
"--spectrum-colorwheel-track-width",
@@ -48,7 +49,7 @@
4849
"--spectrum-border-width-100",
4950
"--spectrum-color-control-track-width",
5051
"--spectrum-disabled-background-color",
51-
"--spectrum-transparent-black-300"
52+
"--spectrum-gray-1000-rgb"
5253
],
5354
"passthroughs": [],
5455
"high-contrast": [

components/colorwheel/index.css

Lines changed: 25 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -11,33 +11,33 @@
1111
* governing permissions and limitations under the License.
1212
*/
1313

14-
/* Windows High Contrast Mode */
15-
@media (forced-colors: active) {
16-
.spectrum-ColorWheel {
17-
--highcontrast-colorwheel-border-color-disabled: GrayText;
18-
--highcontrast-colorwheel-fill-color-disabled: Canvas;
14+
.spectrum-ColorWheel {
15+
--spectrum-colorwheel-width: var(--spectrum-color-wheel-width);
16+
--spectrum-colorwheel-min-width: var(--spectrum-color-wheel-minimum-width);
17+
--spectrum-colorwheel-height: var(--spectrum-color-wheel-width);
1918

20-
forced-color-adjust: none;
21-
}
22-
}
19+
/* @TODO: leveraging the rgb token in this case to achieve the desired border color implementation as rgb + opacity are required by the `rgba` function. */
20+
--spectrum-colorwheel-border-color-rgb: var(--spectrum-gray-1000-rgb);
21+
22+
/* @TODO: using explicit value as `color-wheel-border-opacity` is undefined. */
23+
--spectrum-colorwheel-border-opacity: 0.1;
24+
--spectrum-colorwheel-border-color: rgba(var(--spectrum-colorwheel-border-color-rgb), var(--spectrum-colorwheel-border-opacity));
2325

24-
.spectrum-ColorWheel {
25-
--spectrum-colorwheel-width: var(--mod-colorwheel-width, var(--spectrum-color-wheel-width));
26-
--spectrum-colorwheel-height: var(--mod-colorwheel-height, var(--spectrum-color-wheel-width));
2726
--spectrum-colorwheel-fill-color-disabled: var(--mod-colorwheel-fill-color-disabled, var(--spectrum-disabled-background-color));
28-
--spectrum-colorwheel-border-color: var(--spectrum-transparent-black-300);
2927

30-
--spectrum-colorwheel-border-width: var(--mod-colorwheel-border-width, var(--spectrum-border-width-100));
28+
--spectrum-colorwheel-border-width: var(--spectrum-border-width-100);
3129
--spectrum-colorwheel-track-width: var(--mod-colorwheel-track-width, var(--spectrum-color-control-track-width));
3230

31+
--spectrum-colorwheel-colorarea-margin: var(--spectrum-color-wheel-color-area-margin);
32+
3333
/* stylelint-disable-next-line spectrum-tools/no-unused-custom-properties -- used with JS in calculating the clip-path paths and colorarea-container-size */
3434
--_track-width: var(--spectrum-colorwheel-track-width);
3535
/* stylelint-disable-next-line spectrum-tools/no-unused-custom-properties -- used with JS in calculating the clip-path paths and colorarea-container-size */
3636
--_border-width: var(--spectrum-colorwheel-border-width);
3737

3838
position: relative;
3939
display: block;
40-
min-inline-size: var(--mod-colorwheel-min-width, var(--spectrum-color-wheel-minimum-width));
40+
min-inline-size: var(--mod-colorwheel-min-width, var(--spectrum-colorwheel-min-width));
4141
inline-size: var(--spectrum-colorwheel-width);
4242
block-size: var(--spectrum-colorwheel-height);
4343
user-select: none;
@@ -75,7 +75,7 @@
7575
display: flex;
7676
align-items: center;
7777
justify-content: center;
78-
margin: var(--mod-colorwheel-colorarea-margin, var(--spectrum-color-wheel-color-area-margin));
78+
margin: var(--mod-colorwheel-colorarea-margin, var(--spectrum-colorwheel-colorarea-margin));
7979
}
8080

8181
.spectrum-ColorWheel-slider {
@@ -130,3 +130,13 @@
130130
background: var(--highcontrast-colorwheel-fill-color-disabled, var(--spectrum-colorwheel-fill-color-disabled));
131131
}
132132
}
133+
134+
/* Windows High Contrast Mode */
135+
@media (forced-colors: active) {
136+
.spectrum-ColorWheel {
137+
--highcontrast-colorwheel-border-color-disabled: GrayText;
138+
--highcontrast-colorwheel-fill-color-disabled: Canvas;
139+
140+
forced-color-adjust: none;
141+
}
142+
}

0 commit comments

Comments
 (0)