Skip to content

Commit 85f8493

Browse files
rubencarvalhocastastrophe
authored andcommitted
fix(menu): update menu item border radius (#3504)
* chore(menu): remove mod property and add fallback for spectrum classic
1 parent 07dd418 commit 85f8493

File tree

5 files changed

+13
-1
lines changed

5 files changed

+13
-1
lines changed

.changeset/shiny-files-chew.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@spectrum-css/menu": patch
3+
---
4+
5+
Updated the menu item border radius in Spectrum 2.

components/menu/dist/metadata.json

+4-1
Original file line numberDiff line numberDiff line change
@@ -250,6 +250,7 @@
250250
"--spectrum-menu-item-checkmark-width-medium",
251251
"--spectrum-menu-item-checkmark-width-small",
252252
"--spectrum-menu-item-collapsible-no-icon-submenu-item-padding-x-start",
253+
"--spectrum-menu-item-corner-radius",
253254
"--spectrum-menu-item-description-color-default",
254255
"--spectrum-menu-item-description-color-disabled",
255256
"--spectrum-menu-item-description-color-down",
@@ -332,6 +333,7 @@
332333
"--spectrum-component-top-to-text-200",
333334
"--spectrum-component-top-to-text-300",
334335
"--spectrum-component-top-to-text-75",
336+
"--spectrum-corner-radius-100",
335337
"--spectrum-disabled-content-color",
336338
"--spectrum-divider-thickness-medium",
337339
"--spectrum-divider-thickness-small",
@@ -376,7 +378,8 @@
376378
"system-theme": [
377379
"--system-menu-item-background-color-down",
378380
"--system-menu-item-background-color-hover",
379-
"--system-menu-item-background-color-key-focus"
381+
"--system-menu-item-background-color-key-focus",
382+
"--system-menu-item-corner-radius"
380383
],
381384
"passthroughs": [
382385
"--mod-checkbox-text-to-control",

components/menu/index.css

+2
Original file line numberDiff line numberDiff line change
@@ -370,6 +370,8 @@
370370
position: relative;
371371
align-items: center;
372372

373+
border-radius: var(--spectrum-menu-item-corner-radius);
374+
373375
box-sizing: border-box;
374376

375377
background-color: var(--highcontrast-menu-item-background-color-default, var(--mod-menu-item-background-color-default, var(--spectrum-menu-item-background-color-default)));

components/menu/themes/spectrum-two.css

+1
Original file line numberDiff line numberDiff line change
@@ -16,5 +16,6 @@
1616
--spectrum-menu-item-background-color-hover: rgba(var(--spectrum-gray-1000-rgb), var(--spectrum-transparent-black-200-opacity));
1717
--spectrum-menu-item-background-color-down: rgba(var(--spectrum-gray-1000-rgb), var(--spectrum-transparent-black-200-opacity));
1818
--spectrum-menu-item-background-color-key-focus: rgba(var(--spectrum-gray-1000-rgb), var(--spectrum-transparent-black-200-opacity));
19+
--spectrum-menu-item-corner-radius: var(--spectrum-corner-radius-100);
1920
}
2021
}

components/menu/themes/spectrum.css

+1
Original file line numberDiff line numberDiff line change
@@ -20,5 +20,6 @@
2020
--spectrum-menu-item-background-color-hover: rgba(var(--spectrum-gray-900-rgb), var(--spectrum-transparent-black-200-opacity));
2121
--spectrum-menu-item-background-color-down: rgba(var(--spectrum-gray-900-rgb), var(--spectrum-transparent-black-200-opacity));
2222
--spectrum-menu-item-background-color-key-focus: rgba(var(--spectrum-gray-900-rgb), var(--spectrum-transparent-black-200-opacity));
23+
--spectrum-menu-item-corner-radius: 0;
2324
}
2425
}

0 commit comments

Comments
 (0)