Skip to content

Commit e945e26

Browse files
refactor(menu): improve chromatic cov, prevent checkbox + icon clash(#2757)
- refactor menu item - create single menu item story - create menu with variants story - build chromatic testing views for menu item and menu with variants - remove extra stories in favor of using menu with variants - fix to prevent multiselect checkbox and icon clash CSS-614
1 parent 50a779f commit e945e26

File tree

4 files changed

+673
-363
lines changed

4 files changed

+673
-363
lines changed

.changeset/silly-ties-attend.md

+7
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
"@spectrum-css/menu": patch
3+
---
4+
5+
Prevents overlap of checkbox and icon if both are used in a menu item.
6+
7+
Also reduces a significant number of variants by consolidating menus, includes a refactor to enhance menu item understanding, and expands Chromatic testing coverage.

components/menu/index.css

+1-1
Original file line numberDiff line numberDiff line change
@@ -513,7 +513,7 @@ governing permissions and limitations under the License.
513513
}
514514

515515
.is-selectableMultiple .spectrum-Menu-itemCheckbox {
516-
grid-area: iconArea;
516+
grid-area: checkmarkArea;
517517
}
518518

519519
.spectrum-Menu-checkmark {

0 commit comments

Comments
 (0)