Skip to content

[ActionButton, ActionGroup] examples should be accessible #2853

Open
@astearns

Description

Description

The Storybook Action button (and Action group) examples do not have an accessible name in the icon-only versions. The versions that have a name in the markup have a duplicate aria-label attribute, but the ones that do not have a name in the markup are missing that attribute.

Link to documentation

https://opensource.adobe.com/spectrum-css/preview/index.html?path=/story/components-action-button--default

Additional context

I assume the stories/template should be set up more like the spectrum-Button examples, which add an aria-label attribute for the versions with no markup name, and do not add the attribute for the versions with the name in the markup. I’d be happy to submit a PR with this documentation fix if this is correct.

Metadata

Labels

bugResults from a bug in the CSS implementationdocumentationBecause documentation is important and shouldn't be brokenjira ticket createdsize-2 S~6-18hrs; not hard or time consuming, one or two work days to complete.triageNeeds to be reproduced & prioritized

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions