Skip to content

Commit 39e1c5e

Browse files
authored
TNT-40917-1 Update SDK to use new Delivery client after #18 fix (#19)
* Update SDK to use new Delivery client after #18 fix * Update Delivery client to latest v1.1.1
1 parent db1abbd commit 39e1c5e

File tree

7 files changed

+14
-14
lines changed

7 files changed

+14
-14
lines changed

SampleApp/ProgramSync.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ public static void Main(string[] args)
4242
.SetContext(new Context(ChannelType.Web))
4343
.SetExecute(new ExecuteRequest(null, new List<MboxRequest>
4444
{
45-
new MboxRequest(index:1, name: "a1-serverside-ab")
45+
new (index: 0, name: "a1-serverside-ab")
4646
}))
4747
.Build();
4848

@@ -60,8 +60,8 @@ public static void Main(string[] args)
6060
.SetContext(new Context(ChannelType.Web))
6161
.SetNotifications(new List<Notification>()
6262
{
63-
{ new(id:"notificationId1", type: MetricType.Display, timestamp: DateTimeOffset.UtcNow.ToUnixTimeMilliseconds(),
64-
tokens: new List<string>())}
63+
new (id:"notificationId1", type: MetricType.Display, timestamp: DateTimeOffset.UtcNow.ToUnixTimeMilliseconds(),
64+
tokens: new List<string>())
6565
})
6666
.Build();
6767

@@ -81,7 +81,7 @@ private static void DecisioningReady()
8181
.SetContext(new Context(ChannelType.Web, geo: new Geo("193.105.140.131")))
8282
.SetExecute(new ExecuteRequest(new RequestDetails(), new List<MboxRequest>
8383
{
84-
new(index:1, name: "a1-mobile-tstsree")
84+
new (index: 1, name: "a1-mobile-tstsree")
8585
}))
8686
.Build();
8787

Source/Adobe.Target.Client/Adobe.Target.Client.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414
<ItemGroup Label="Project References">
1515
<PackageReference Include="Adobe.ExperienceCloud.Ecid" Version="1.0.0" />
16-
<PackageReference Include="Adobe.Target.Delivery" Version="1.0.0" />
16+
<PackageReference Include="Adobe.Target.Delivery" Version="1.1.1" />
1717
<PackageReference Include="JsonLogic.Net" Version="1.1.9" />
1818
<PackageReference Include="Microsoft.CSharp" Version="4.7.0" />
1919
<PackageReference Include="Microsoft.Extensions.Logging" Version="5.0.0" />

Source/Adobe.Target.Client/Extension/DeliveryRequestExtension.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ namespace Adobe.Target.Client.Extension
1717

1818
internal static class DeliveryRequestExtension
1919
{
20-
internal static void AddTelemetry(this TargetDeliveryRequest request, TargetClientConfig config, int execution = 0)
20+
internal static void AddTelemetry(this TargetDeliveryRequest request, TargetClientConfig config, int? execution = default)
2121
{
2222
var telemetryEntry = request.GetTelemetryEntry(config, execution);
2323
if (telemetryEntry == null)
@@ -30,7 +30,7 @@ internal static void AddTelemetry(this TargetDeliveryRequest request, TargetClie
3030
deliveryRequest.Telemetry.Entries.Add(telemetryEntry);
3131
}
3232

33-
internal static TelemetryEntry GetTelemetryEntry(this TargetDeliveryRequest request, TargetClientConfig config, int execution = 0)
33+
internal static TelemetryEntry GetTelemetryEntry(this TargetDeliveryRequest request, TargetClientConfig config, int? execution = default)
3434
{
3535
if (!config.TelemetryEnabled)
3636
{

Source/Adobe.Target.Client/Model/TargetDeliveryRequest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ public Builder SetImpressionId(string impressionId)
180180
/// </summary>
181181
/// <param name="environmentId">Environment Id</param>
182182
/// <returns><see cref="Builder"/> instance</returns>
183-
public Builder SetEnvironmentId(long environmentId)
183+
public Builder SetEnvironmentId(long? environmentId)
184184
{
185185
this.DeliveryRequest.EnvironmentId = environmentId;
186186
return this;

Source/Adobe.Target.Client/OnDevice/GeoClient.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ private bool ValidateGeo(Geo geo)
5252
{
5353
return geo != null && !string.IsNullOrEmpty(geo.IpAddress) && string.IsNullOrEmpty(geo.City)
5454
&& string.IsNullOrEmpty(geo.StateCode) && string.IsNullOrEmpty(geo.CountryCode)
55-
&& geo.Latitude == 0 && geo.Longitude == 0;
55+
&& geo.Latitude == null && geo.Longitude == null;
5656
}
5757

5858
private Geo HeadersToGeo(Geo originalGeo, IRestResponse response)

Source/Adobe.Target.Client/TargetClient.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ private static TargetDeliveryRequest AddMBoxesToRequest(TargetDeliveryRequest re
150150
{
151151
if (mbox.Index >= index)
152152
{
153-
index = mbox.Index + 1;
153+
index = (int)mbox.Index + 1;
154154
}
155155

156156
existingMboxNames.Add(mbox.Name);

Tests/Adobe.Target.Client.Test/Util/IntegrationTestUtils.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@ public static EquivalencyAssertionOptions<DeliveryRequest> RootRequestEquivalenc
206206
ctx.Subject.Should().Be(ctx.Expectation);
207207
})
208208
.When(info => info.Type == typeof(string))
209-
.Using<long>(ctx =>
209+
.Using<long?>(ctx =>
210210
{
211211
if (ctx.Expectation == -999L)
212212
{
@@ -216,8 +216,8 @@ public static EquivalencyAssertionOptions<DeliveryRequest> RootRequestEquivalenc
216216

217217
ctx.Subject.Should().Be(ctx.Expectation);
218218
})
219-
.When(info => info.Type == typeof(long))
220-
.Using<int>(ctx =>
219+
.When(info => info.Type == typeof(long?))
220+
.Using<int?>(ctx =>
221221
{
222222
if (ctx.Expectation == -999)
223223
{
@@ -227,7 +227,7 @@ public static EquivalencyAssertionOptions<DeliveryRequest> RootRequestEquivalenc
227227

228228
ctx.Subject.Should().Be(ctx.Expectation);
229229
})
230-
.When(info => info.Type == typeof(int))
230+
.When(info => info.Type == typeof(int?))
231231
.WithTracing();
232232
}
233233
}

0 commit comments

Comments
 (0)