Skip to content

Commit 550bd60

Browse files
authored
Additional logging for ODD notifications (#38)
1 parent 3056747 commit 550bd60

File tree

2 files changed

+7
-0
lines changed

2 files changed

+7
-0
lines changed

Source/Adobe.Target.Client/Service/OnDeviceDecisioningService.cs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,7 @@ public TargetDeliveryResponse ExecuteRequest(TargetDeliveryRequest deliveryReque
8787
var ruleSet = this.ruleLoader.GetLatestRules();
8888
if (ruleSet == null)
8989
{
90+
TargetClient.Logger?.LogWarning("Decisioning rules not loaded, returning empty response");
9091
var deliveryResponse = new DeliveryResponse(
9192
(int)HttpStatusCode.ServiceUnavailable,
9293
deliveryRequest.DeliveryRequest.RequestId,
@@ -203,11 +204,16 @@ private void HandleDetails(
203204

204205
private void SendNotifications(TargetDeliveryRequest request, TargetDeliveryResponse targetResponse, List<Notification> notifications, TelemetryEntry telemetryEntry)
205206
{
207+
TargetClient.Logger?.LogDebug("Sending notifications for requestId: {requestId} sessionId: {sessionId}", request.DeliveryRequest.RequestId, request.SessionId);
208+
206209
if (notifications.Count == 0 && telemetryEntry == null)
207210
{
211+
TargetClient.Logger?.LogDebug("No notifications to send");
208212
return;
209213
}
210214

215+
TargetClient.Logger?.LogDebug("Notifications: {notifications}", string.Join(", ", notifications));
216+
211217
var deliveryRequest = request.DeliveryRequest;
212218
var locationHint = request.LocationHint ?? this.clusterLocator.GetLocationHint();
213219
var telemetry = telemetryEntry != null ? new Telemetry(new List<TelemetryEntry> { telemetryEntry }) : null;

Source/Adobe.Target.Client/Service/TargetService.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,7 @@ private TargetDeliveryResponse GetTargetDeliveryResponse(TargetDeliveryRequest r
112112
{
113113
if (response == null)
114114
{
115+
this.logger?.LogWarning("Null response for requestId: {requestId}, sessionId: {sessionId}", request.DeliveryRequest.RequestId, request.SessionId);
115116
return new TargetDeliveryResponse(request, null, HttpStatusCode.ServiceUnavailable);
116117
}
117118

0 commit comments

Comments
 (0)