Skip to content

Commit d53a205

Browse files
dbasunagadolfo-ab
authored andcommitted
remove unnecessary argument from function call (opendatahub-io#255)
* on rebase clean commented-by- labels * remove unnecessary argument from function call
1 parent a86e846 commit d53a205

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

tests/model_registry/conftest.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -185,12 +185,9 @@ def model_registry_instance_service(
185185

186186
@pytest.fixture(scope="class")
187187
def model_registry_instance_rest_endpoint(
188-
admin_client: DynamicClient,
189188
model_registry_instance_service: Service,
190189
) -> str:
191-
return get_endpoint_from_mr_service(
192-
client=admin_client, svc=model_registry_instance_service, protocol=Protocols.REST
193-
)
190+
return get_endpoint_from_mr_service(svc=model_registry_instance_service, protocol=Protocols.REST)
194191

195192

196193
@pytest.fixture(scope="class")

tests/model_registry/utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ def get_mr_service_by_label(client: DynamicClient, ns: Namespace, mr_instance: M
4040
raise ResourceNotFoundError(f"{mr_instance.name} has no Service")
4141

4242

43-
def get_endpoint_from_mr_service(client: DynamicClient, svc: Service, protocol: str) -> str:
43+
def get_endpoint_from_mr_service(svc: Service, protocol: str) -> str:
4444
if protocol in (Protocols.REST, Protocols.GRPC):
4545
return svc.instance.metadata.annotations[f"{ADDRESS_ANNOTATION_PREFIX}{protocol}"]
4646
else:

0 commit comments

Comments
 (0)