Remove action helper

Author: RobbieTheWagner

tests/dummy/app/controllers/index.js

@@ -4,6 +4,7 @@ import { action } from '@ember/object';
 
 import { dropTask, timeout } from 'ember-concurrency';
 import RSVP from 'rsvp';
+import { tracked } from '@glimmer/tracking';
 
 export default class IndexController extends Controller {
   simple1 = A([
@@ -134,7 +135,7 @@ export default class IndexController extends Controller {
 
   sourceOnly2 = A([{ name: 'Quux' }]);
 
-  networkFailure = false;
+  @tracked networkFailure = false;
 
   @action
   dragEnd({ sourceList, sourceIndex, targetList, targetIndex }) {
@@ -200,6 +201,10 @@ export default class IndexController extends Controller {
     );
   }
 
+  updateNetworkFailure = (event) => {
+    this.networkFailure = event.target.checked;
+  };
+
   dragEndTask = dropTask(
     async ({ sourceList, sourceIndex, targetList, targetIndex }) => {
       if (sourceList === targetList && sourceIndex === targetIndex)

tests/dummy/app/templates/index.hbs

@@ -89,7 +89,7 @@
         <input
           type="checkbox"
           checked={{this.networkFailure}}
-          onclick={{action (mut this.networkFailure) value="target.checked"}}
+          {{on "change" this.updateNetworkFailure}}
         />
         Simulate network failure.
       </label>

tests/dummy/config/ember-try.js

@@ -11,6 +11,7 @@ module.exports = async function () {
         name: 'ember-lts-3.28',
         npm: {
           devDependencies: {
+            '@ember/test-helpers': '^2.9.3',
             'ember-cli': '~4.12.0',
             'ember-qunit': '^6.0.0',
             'ember-resolver': '^10.0.0',
@@ -22,7 +23,10 @@ module.exports = async function () {
         name: 'ember-lts-4.4',
         npm: {
           devDependencies: {
+            '@ember/test-helpers': '^2.9.3',
             'ember-cli': '~4.12.0',
+            'ember-qunit': '^6.0.0',
+            'ember-resolver': '^10.0.0',
             'ember-source': '~4.4.0',
           },
         },
@@ -31,7 +35,10 @@ module.exports = async function () {
         name: 'ember-lts-4.8',
         npm: {
           devDependencies: {
+            '@ember/test-helpers': '^2.9.3',
             'ember-cli': '~4.12.0',
+            'ember-qunit': '^6.0.0',
+            'ember-resolver': '^10.0.0',
             'ember-source': '~4.8.0',
           },
         },