Skip to content

Update the Exclude data slider in MetricsDetails page#1237

Open
dennycjacob wants to merge 1 commit into
adoptium:masterfrom
dennycjacob:refactor_exclude_slider
Open

Update the Exclude data slider in MetricsDetails page#1237
dennycjacob wants to merge 1 commit into
adoptium:masterfrom
dennycjacob:refactor_exclude_slider

Conversation

@dennycjacob
Copy link
Copy Markdown
Contributor

@netlify
Copy link
Copy Markdown

netlify Bot commented May 25, 2026

Deploy Preview for eclipsefdn-adoptium-trss ready!

Name Link
🔨 Latest commit 6f714f4
🔍 Latest deploy log https://app.netlify.com/projects/eclipsefdn-adoptium-trss/deploys/6a147999f14ffb0008bcfca2
😎 Deploy Preview https://deploy-preview-1237--eclipsefdn-adoptium-trss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@dennycjacob
Copy link
Copy Markdown
Contributor Author

Current Behavior:

Screen.Recording.2026-05-25.at.12.33.51.PM.mov


};

// const uniqueTitle = [...new Set(data.map((item) => item.metricName))];
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete the commented out line uniqueTitle

@annaibm
Copy link
Copy Markdown
Contributor

annaibm commented May 26, 2026

Suggestion (can be a follow-up issue): The stats calculation logic is duplicated between the useEffect and the table summary function — same math, only difference is CI formatting ("38.47" vs "38.47%"). Could be extracted into a shared calculateStats(values, formatCI) helper so if the formula changes it only needs updating in one place. Happy to open an issue for this if useful.?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants