Skip to content

User inputs to get.sh are no longer overwritten, even when USE_TESTENV_PROPERTIES=true#7129

Open
jmjaffe37 wants to merge 3 commits into
adoptium:masterfrom
jmjaffe37:jmj/respect_inputs
Open

User inputs to get.sh are no longer overwritten, even when USE_TESTENV_PROPERTIES=true#7129
jmjaffe37 wants to merge 3 commits into
adoptium:masterfrom
jmjaffe37:jmj/respect_inputs

Conversation

@jmjaffe37
Copy link
Copy Markdown
Contributor

Currently, if a user sets USE_TESTENV_PROPERTIES=true, then inputs like "--tkg_repo" and "--tkg_branch" are ignored. This PR ensures that they are no-longer ignored.

@jmjaffe37 jmjaffe37 changed the title User inputs are no longer overwritten, even when USE_TESTENV_PROPERTIES=true User inputs to get.sh are no longer overwritten, even when USE_TESTENV_PROPERTIES=true May 27, 2026
@smlambert
Copy link
Copy Markdown
Contributor

USE_TESTENV_PROPERTIES=true was never meant to be overwritten, it was meant to guarantee that the values in the testenv.properties file were the ones used.

@karianna
Copy link
Copy Markdown
Contributor

USE_TESTENV_PROPERTIES=true was never meant to be overwritten, it was meant to guarantee that the values in the testenv.properties file were the ones used.

Should this be closed in that case?

@smlambert
Copy link
Copy Markdown
Contributor

Should this be closed in that case?

Before closing, I guess we should ensure that whatever the use case that @jmjaffe37 is trying to address is accomplished by USE_TESTENV_PROPERTIES=false (or not setting it, as the default value is false), and then overwriting any of the test repositories parameters (as listed in this documentation: https://github.com/adoptium/aqa-tests/blob/master/docs/pages/JenkinFeatures.md#test-repositories-parameters).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants