User inputs to get.sh are no longer overwritten, even when USE_TESTENV_PROPERTIES=true#7129
User inputs to get.sh are no longer overwritten, even when USE_TESTENV_PROPERTIES=true#7129jmjaffe37 wants to merge 3 commits into
Conversation
|
USE_TESTENV_PROPERTIES=true was never meant to be overwritten, it was meant to guarantee that the values in the testenv.properties file were the ones used. |
Should this be closed in that case? |
Before closing, I guess we should ensure that whatever the use case that @jmjaffe37 is trying to address is accomplished by USE_TESTENV_PROPERTIES=false (or not setting it, as the default value is false), and then overwriting any of the test repositories parameters (as listed in this documentation: https://github.com/adoptium/aqa-tests/blob/master/docs/pages/JenkinFeatures.md#test-repositories-parameters). |
Currently, if a user sets USE_TESTENV_PROPERTIES=true, then inputs like "--tkg_repo" and "--tkg_branch" are ignored. This PR ensures that they are no-longer ignored.