Extra packages listed in dependencies

[stsievert]

Why are the packages required to build the documentation listed under the dependencies?

scikeras/pyproject.toml

Lines 31 to 45 in d1a9d12

	[tool.poetry.dependencies]
	importlib-metadata = {version = "^3.4.0", python = "<3.8"}
	python = ">=3.6.7, <3.9"
	scikit-learn = "^0.22.0"
	tensorflow = "^2.4.0"
	# docs
	insipid-sphinx-theme = {version = "^0.2.2", optional = true}
	ipykernel = {version = "^5.4.2", optional = true}
	jupyter = {version = "^1.0.0", optional = true}
	jupytext = {version = "^1.9.1", optional = true}
	matplotlib = {version = "^3.3.3", optional = true}
	nbsphinx = {version = "^0.8.1", optional = true}
	numpydoc = {version = "^1.1.0", optional = true}
	sphinx = {version = ">=3.2.1", optional = true}

Yes, they're optional (which is good). But only devs build docs. Why not list ipykernel/jupyter/etc there?

[adriangb]

The only reason is that then if you don't plan on building docs, you still end up with a ton of extra stuff installed, which is not the end of the world, but not great either. Ideally, we'd want it to be dev and extras, but that's not possible, so I originally settled for it being an extra. The name of the extra, dev_docs makes it pretty clear that it's for developers.

But I am open to the idea of just moving it to be regular dev deps.

[stsievert]

Somewhat relevant: #210 (comment)