Close stop channel if we receive error

Author: adrianmoisey

vertical-pod-autoscaler/pkg/recommender/main.go

@@ -153,6 +153,12 @@ func run(ctx context.Context, healthCheck *metrics.HealthCheck, config *recommen
 		stopCh,
 	)
 
+	if err != nil {
+		close(stopCh) // Clean up any started routines
+		klog.ErrorS(err, "Failed to create recommender controller")
+		klog.FlushAndExit(klog.ExitFlushTimeout, 1)
+	}
+
 	factory.Start(stopCh)
 	informerMap := factory.WaitForCacheSync(stopCh)
 	for kind, synced := range informerMap {
@@ -162,11 +168,6 @@ func run(ctx context.Context, healthCheck *metrics.HealthCheck, config *recommen
 		}
 	}
 
-	if err != nil {
-		klog.ErrorS(err, "Failed to create recommender controller")
-		klog.FlushAndExit(klog.ExitFlushTimeout, 1)
-	}
-
 	if err := controller.Run(ctx); err != nil {
 		klog.ErrorS(err, "Recommender controller exited with error")
 		klog.FlushAndExit(klog.ExitFlushTimeout, 1)

vertical-pod-autoscaler/test/integration/recommender/util.go

@@ -158,6 +158,7 @@ func recommenderSetup(t *testing.T, recommenderConfig *recommender_config.Recomm
 		stopCh,
 	)
 	if err != nil {
+		close(stopCh) // Clean up any started routines
 		t.Fatalf("Error creating recommender controller: %v", err)
 	}