Skip to content

Commit e6d4ad3

Browse files
committed
Minor refactoring
1 parent 6be996c commit e6d4ad3

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

src/mode/ascii-mode-strategy.test.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,21 +3,22 @@ import {Converters} from "../converters";
33
import {ReportType} from "./mode-startegy";
44

55
describe('AsciiModeStrategy', () => {
6-
const validFrame = ':0401000A000DE4\r\n';
6+
const validFrameBytes = [4, 1, 0, 10, 0, 0x0D];
7+
const validFrame = `:${Converters.bytesAsHex(validFrameBytes)}E4\r\n`;
78

89
test('accept a valid frame', () => {
910
const instance = new AsciiModeStrategy(jest.fn());
1011

1112
instance.receive(Converters.textAsUInt8Array(validFrame));
1213

1314
expect(instance.report).toHaveBeenCalledTimes(1);
14-
expect(instance.report).toHaveBeenCalledWith([0x04, 0x01, 0x00, 0x0A, 0x00, 0x0D], ReportType.valid);
15+
expect(instance.report).toHaveBeenCalledWith(validFrameBytes, ReportType.valid);
1516
});
1617

1718
test('calculates the correct LRC on send', () => {
1819
const instance = new AsciiModeStrategy(jest.fn());
1920

20-
let result = instance.send([0x04, 0x01, 0x00, 0x0A, 0x00, 0x0D]);
21+
let result = instance.send(validFrameBytes);
2122

2223
expect(result).toEqual(Converters.textAsUInt8Array(validFrame));
2324
expect(instance.report).toHaveBeenCalledTimes(0);

0 commit comments

Comments
 (0)