tests against EXP@devel not running

[lgarrison]

We have the Gala tests set up to run against the EXP devel branch when the Gala branch being tested is also devel (otherwise a tagged EXP version is used). However, it doesn't look like there is a Gala devel branch anymore! I think that's why the Gala tests didn't notice the missing EXP header reported in Slack.

@adrn What do you think we should do here? We could make the scheduled tests run against EXP devel, for example, while keeping regular tests against a tagged EXP version.

This is the relevant part of the Gala workflow:

gala/.github/workflows/tests.yml

Lines 42 to 43 in df919dd

	# Run tests against a tagged EXP version, unless this is the devel branch or a PR into devel, in which case test against EXP devel
	EXP_REF: ${{ (github.ref == 'refs/heads/devel' || (github.event_name == 'pull_request' && github.event.pull_request.base.ref == 'devel')) && 'devel' || 'v7.9.1' }}

cc @The9Cat

[The9Cat]

Ah. I am also wondering how we make sure that the Gala build doesn't get broken by future EXP changes. We could include the Gala build in the GitHub CI but that seems over the top, no? But it would have caught the latest build problem.

I'm happy to help implement whatever choice makes the most sense.

[The9Cat]

Looking at tests.yml above: the final step in the EXP_REF logic tests against the v7.9.1 tag which an old tag for the head of main which does not include the breaking change. The breaking change in v7.9.3 which is a a recent bug fix to main.