SciX ID Prefix in Grammar (#245)

* Add 'scix:' as a special case in the grammar

* Add query processor to special case SciX ID queries

Author: JCRPaquin

montysolr/src/main/antlr/ADS.g

@@ -321,7 +321,8 @@ identifier
   //IDENTIFIER  
   ('doi:' -> QNORMAL["doi"]
   |'arxiv:' -> QNORMAL["arxiv"]
-  |'arXiv:'  -> QNORMAL["arxiv"])
+  |'arXiv:'  -> QNORMAL["arxiv"]
+  |'scix:' -> QNORMAL["scix"])
   (TERM_NORMAL -> $identifier TERM_NORMAL
   | PHRASE_ANYTHING  -> $identifier ^(QPHRASETRUNC PHRASE_ANYTHING)
   | PHRASE -> $identifier ^(QPHRASE PHRASE)

montysolr/src/main/java/org/apache/lucene/queryparser/flexible/aqp/AqpAdsabsNodeProcessorPipeline.java

@@ -77,6 +77,7 @@ public AqpAdsabsNodeProcessorPipeline(QueryConfigHandler queryConfig) {
         add(new AqpAdsabsQTRUNCATEDProcessor());
         add(new AqpQANYTHINGProcessor());
         add(new AqpQIDENTIFIERProcessor());
+        add(new AqpScixIDProcessor());
         add(new AqpFIELDProcessor()); // sets the field name (if user specified one, or there is a default)
 
 

montysolr/src/main/java/org/apache/lucene/queryparser/flexible/aqp/processors/AqpScixIDProcessor.java

@@ -0,0 +1,45 @@
+package org.apache.lucene.queryparser.flexible.aqp.processors;
+
+import org.apache.lucene.queryparser.flexible.aqp.nodes.AqpANTLRNode;
+import org.apache.lucene.queryparser.flexible.aqp.nodes.AqpAdsabsIdentifierNode;
+import org.apache.lucene.queryparser.flexible.core.QueryNodeException;
+import org.apache.lucene.queryparser.flexible.core.nodes.QueryNode;
+import org.apache.lucene.queryparser.flexible.core.processors.QueryNodeProcessorImpl;
+
+import java.util.List;
+
+/**
+ * Special case processor for SciX IDs
+ * <br/>
+ * We'd like "identifier:scix:XXX-XXX-XXX" queries to work, but the other elements of the
+ * query processing pipeline remove the "scix:" prefix from the query. This adds the prefix
+ * back in to ensure the query term can match the indexed term.
+ */
+public class AqpScixIDProcessor extends QueryNodeProcessorImpl {
+
+
+    @Override
+    protected QueryNode preProcessNode(QueryNode node) throws QueryNodeException {
+        if (node instanceof AqpAdsabsIdentifierNode identifierNode) {
+            if (identifierNode.getFieldAsString().equals("scix")) {
+                return new AqpAdsabsIdentifierNode(
+                        identifierNode.getField(),
+                        identifierNode.getFieldAsString() + ":" + identifierNode.getTextAsString(),
+                        identifierNode.getBegin(),
+                        identifierNode.getEnd());
+            }
+        }
+
+        return node;
+    }
+
+    @Override
+    protected QueryNode postProcessNode(QueryNode node) throws QueryNodeException {
+        return node;
+    }
+
+    @Override
+    protected List<QueryNode> setChildrenOrder(List<QueryNode> children) throws QueryNodeException {
+        return children;
+    }
+}