Javascript fix, offsetParent can be null when not visible

AlanDrake · AlanDrake · commit 40fc297597a5 · 2025-06-20T22:51:51.000+02:00
diff --git a/html/template_navigation.js b/html/template_navigation.js
@@ -69,7 +69,9 @@ window.addEventListener('DOMContentLoaded', () => {
 		}
 		
 		// center sidebar to active topic
-		const bounds = active_topic.offsetParent.getBoundingClientRect();
-		active_topic.offsetParent.scrollTop = active_topic.offsetTop - bounds.height/2;
+		if (active_topic.offsetParent) {
+			const bounds = active_topic.offsetParent.getBoundingClientRect();
+			active_topic.offsetParent.scrollTop = active_topic.offsetTop - bounds.height/2;
+		}
 	}
 });

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,9 @@ window.addEventListener('DOMContentLoaded', () => {`
`69`	`69`	`}`
`70`	`70`
`71`	`71`	`// center sidebar to active topic`
`72`		`- const bounds = active_topic.offsetParent.getBoundingClientRect();`
`73`		`- active_topic.offsetParent.scrollTop = active_topic.offsetTop - bounds.height/2;`
	`72`	`+ if (active_topic.offsetParent) {`
	`73`	`+ const bounds = active_topic.offsetParent.getBoundingClientRect();`
	`74`	`+ active_topic.offsetParent.scrollTop = active_topic.offsetTop - bounds.height/2;`
	`75`	`+ }`
`74`	`76`	`}`
`75`	`77`	`});`