Skip to content

Commit 61625b6

Browse files
authored
Merge pull request #2831 from ericoporto/fix-editor-go-to-id-multitype
Editor: fix typing of multi-digit IDs
2 parents 23a3a52 + b16dad9 commit 61625b6

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

Editor/AGS.Editor/GUI/GoToNumberDialog.Designer.cs

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Editor/AGS.Editor/GUI/GoToNumberDialog.cs

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -104,11 +104,16 @@ private bool ExistInList (int number)
104104
return GetItemByNumber(number) != null;
105105
}
106106

107+
private void EnableOkButtonIfNumberExists()
108+
{
109+
btnOk.Enabled = ExistInList(Number);
110+
}
111+
107112
private void syncFromUpDownToListBox()
108113
{
114+
EnableOkButtonIfNumberExists();
109115
if (ExistInList(Number))
110116
{
111-
btnOk.Enabled = true;
112117
Tuple<int, string> selected = GetItemByNumber(Number);
113118
if (selected != lstNodes.SelectedItem)
114119
{
@@ -117,7 +122,6 @@ private void syncFromUpDownToListBox()
117122
}
118123
else
119124
{
120-
btnOk.Enabled = false;
121125
lstNodes.SelectedItem = null;
122126
lstNodes.Invalidate();
123127
}
@@ -142,7 +146,9 @@ private void upDownNumber_ValueChanged(object sender, EventArgs e)
142146

143147
private void upDownNumber_KeyUp(object sender, KeyEventArgs e)
144148
{
145-
syncFromUpDownToListBox();
149+
// if we sync the list will then erase back the upDown number
150+
// so we only disable the ok button if the number is invalid
151+
EnableOkButtonIfNumberExists();
146152
}
147153

148154
private void lstNodes_SelectedValueChanged(object sender, EventArgs e)

0 commit comments

Comments
 (0)