AGS 4: New compiler: reports undeclared function with incorrect line

[ivan-mogilko]

Problem

New script compiler reports a line 1-2 numbers above the actual line when there's a function call of an undeclared function. I noticed that using undeclared variables in some expression does not cause the same problem, but I am not fully certain that this is not a accident.

How to reproduce

Go anywhere in script and type e.g.

CallWrongFunction();

then compile.

The compiler will report identifier 'CallWrongFunction' is undeclared, but the reported line is 1-2 numbers less than the actual line.

[fernewelten]

Behind-the-scenes, the new compiler doesn't track line numbers directly. It tracks symbol positions. When it emits an error message, it converts the last symbol read to the line that the symbol is in and reports that line number.

So my guess is that the compiler has only peeked at the unknown symbol when it emits the error, so that the "cursor" is still at the symbol in front of the unknown symbol. Depending on how much whitespace is between the unknown symbol and the symbol in front, that would result in one or more lines "early".

Edit And that exactly turned out to be the case.
lssuing #2905 as a fix.

[ivan-mogilko]

Fixed by #2905