Skip to content

[Bug]: "Match" has a slow race condition with user input #2231

Open
@wtanksleyjr

Description

@wtanksleyjr

Describe the issue

After accepting metadata changes from a Match operation (from the dropdown on the book's library item), the edit-book modal dialog is offered to the user as though ready for editing. But if the user makes any changes before the system completely removes the green "Item details updated" banner, the user edits will be removed and reset to the book's state immediately following the Match.

Ideally, I'd like the modal dialogue to be ready for user input immediately after the dialogue appears. If that's not possible, it would be better to make the modal not editable until user input can be preserved.

Steps to reproduce the issue

  1. This is a "slow race", but time still matters. Read the steps before trying to recreate it.
  2. "Match" a book (probably using the drop-down). Accept all offered metadata, and press OK.
  3. You'll be taken to the book-edit modal dialog. Observe the green "Item Details Updated" banner, its disappearance marks the race condition.
  4. While the green banner is still showing, delete one of the genres, or an author, or something else convenient.
  5. Wait for the green ribbon to retract.
  6. As soon as the banner is gone, all of the user changes will be reverted to the results of the match.
  7. Desired behavior: don't revert user input.

Audiobookshelf version

2.4.4

How are you running audiobookshelf?

Docker

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingunable to reproduceIssue is not yet reproduciblewaitingWaiting for OP

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions