Merge pull request #8 from adwise-fiu/fix-api

Author: AndrewQuijano

.github/workflows/test_library.yml

@@ -24,7 +24,7 @@ jobs:
           distribution: 'oracle'
           java-version: '17'
           cache: 'gradle'
-      - run: sh gradlew test --continue
+      - run: sh gradlew test
 
       - name: Upload coverage reports to Codecov
         uses: codecov/codecov-action@v4

build.gradle

@@ -22,14 +22,15 @@ java {
 }
 
 dependencies {
-    implementation 'junit:junit:4.13.2'
+    // Only use full log4j API in testing, but in deployment use API for others to use the library
+    // https://mvnrepository.com/artifact/org.apache.logging.log4j/log4j-core
+    testImplementation 'org.apache.logging.log4j:log4j-core:2.24.3'
+    testImplementation 'junit:junit:4.13.2'
     testImplementation 'org.junit.jupiter:junit-jupiter-api:5.11.0-M1'
-    testRuntimeOnly 'org.junit.jupiter:junit-jupiter-engine:5.10.2'
+    // https://mvnrepository.com/artifact/org.apache.logging.log4j/log4j-api
+    implementation 'org.apache.logging.log4j:log4j-api:2.24.3'
     // https://mvnrepository.com/artifact/commons-io/commons-io
     implementation 'commons-io:commons-io:2.16.1'
-    // or the latest version available
-    implementation 'org.apache.logging.log4j:log4j-core:3.0.0-beta1'
-
     implementation fileTree(dir: 'libs', include: ['*.jar'])
 }
 

src/main/java/edu/fiu/adwise/homomorphic_encryption/misc/NTL.java

@@ -131,19 +131,11 @@ public static BigInteger quadratic_non_residue(BigInteger p, BigInteger q) {
 	 * @return The bit value (0 or 1) at position {@code k}, or 0 if {@code k} is out of range.
 	 */
 	public static int bit(BigInteger a, long k) {
-		//If the value k (location of bit is bigger than a
-		if (k >= a.bitLength()) {
+		int len = a.bitLength();
+		if (k < 0 || k >= len) {
 			return 0;
 		}
-		if (k < 0) {
-			return 0;
-		}
-		String bit = a.toString(2); // get it in Binary
-		if (bit.charAt((int) k)== '0') {
-			return 0;
-		}
-		else {
-			return 1;
-		}
+		int bitIndex = len - 1 - (int) k;
+		return a.abs().testBit(bitIndex) ? 1 : 0;
 	}
 }