Skip to content

Commit 55c50d0

Browse files
authored
chore(catalog): allow empty sources list (kubeflow#1957)
Always return items from the sources endpoint, even if it's an empty list. Signed-off-by: Paul Boyd <paul@pboyd.io>
1 parent c6e5a98 commit 55c50d0

4 files changed

Lines changed: 15 additions & 19 deletions

File tree

api/openapi/catalog.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -606,6 +606,8 @@ components:
606606
type: array
607607
items:
608608
$ref: "#/components/schemas/CatalogSource"
609+
required:
610+
- items
609611
- $ref: "#/components/schemas/BaseResourceList"
610612
Error:
611613
description: Error code and message.

api/openapi/src/catalog.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -489,6 +489,8 @@ components:
489489
type: array
490490
items:
491491
$ref: "#/components/schemas/CatalogSource"
492+
required:
493+
- items
492494
- $ref: "#/components/schemas/BaseResourceList"
493495
FilterOption:
494496
type: object

catalog/internal/server/openapi/type_asserts.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -262,6 +262,7 @@ func AssertCatalogSourceListRequired(obj model.CatalogSourceList) error {
262262
"nextPageToken": obj.NextPageToken,
263263
"pageSize": obj.PageSize,
264264
"size": obj.Size,
265+
"items": obj.Items,
265266
}
266267
for name, el := range elements {
267268
if isZero := IsZeroValue(el); isZero {

catalog/pkg/openapi/model_catalog_source_list.go

Lines changed: 10 additions & 19 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)