fix(core): use toObject to hide owner field

Author: Juknum

src/modules/files/files.controller.ts

@@ -25,7 +25,7 @@ export class FilesController {
 		const file = await this.filesService.findOne(id);
 		await file.visibility?.init();
 
-		if (await this.filesService.canReadFile(file, req.user as User)) return file;
+		if (await this.filesService.canReadFile(file, req.user as User)) return file.toObject();
 		throw new UnauthorizedException(this.t.Errors.File.Unauthorized(file.visibility?.name));
 	}
 }

src/modules/promotions/entities/promotion-picture.entity.ts

@@ -13,7 +13,7 @@ export class PromotionPicture extends File<Promotion> implements PromotionPictur
 	@OneToOne(() => Promotion, (promotion) => promotion.picture, { nullable: true, owner: true })
 	picture_promotion: Promotion;
 
-	@Property({ persist: false })
+	@Property({ persist: false, hidden: true })
 	get owner(): Promotion {
 		return this.picture_promotion;
 	}

src/modules/users/entities/user-banner.entity.ts

@@ -13,7 +13,7 @@ export class UserBanner extends File<User> implements UserBannerEntity<User> {
 	@OneToOne(() => User, (user) => user.banner, { nullable: true, owner: true })
 	banner_user: User;
 
-	@Property({ persist: false })
+	@Property({ persist: false, hidden: true })
 	get owner(): User {
 		return this.banner_user;
 	}

src/modules/users/entities/user-picture.entity.ts

@@ -13,7 +13,7 @@ export class UserPicture extends File<User> implements UserPictureEntity<User> {
 	@OneToOne(() => User, (user) => user.picture, { nullable: true, owner: true })
 	picture_user: User;
 
-	@Property({ persist: false })
+	@Property({ persist: false, hidden: true })
 	get owner(): User {
 		return this.picture_user;
 	}

tests/e2e/files.e2e-spec.ts

@@ -120,7 +120,6 @@ describe('Files (e2e)', () => {
 					id: file.id,
 					filename: 'test.png',
 					mimetype: 'image/png',
-					path: 'test.png',
 					size: 123,
 					visibility: file.visibility.id,
 					description: 'foo bar',