Skip to content

Commit 57c8ece

Browse files
authored
Fix CR api group name (#16)
Fixes from comments #15 - Fix API group name for custom resources - remove unnecessary comment lines
1 parent 756f1a2 commit 57c8ece

File tree

9 files changed

+16
-19
lines changed

9 files changed

+16
-19
lines changed

api/v1alpha1/etcdcluster_types.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,6 @@ import (
2121
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
2222
)
2323

24-
// EDIT THIS FILE! THIS IS SCAFFOLDING FOR YOU TO OWN!
25-
// NOTE: json tags are required. Any new fields you add must have json tags for the fields to be serialized.
26-
2724
type Storage struct {
2825
StorageClass string `json:"storageClass"`
2926
Size resource.Quantity `json:"size"`

api/v1alpha1/groupversion_info.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ limitations under the License.
1616

1717
// Package v1alpha1 contains API Schema definitions for the etcd.aenix.io v1alpha1 API group
1818
// +kubebuilder:object:generate=true
19-
// +groupName=etcd.aenix.io.etcd.aenix.io
19+
// +groupName=etcd.aenix.io
2020
package v1alpha1
2121

2222
import (
@@ -26,7 +26,7 @@ import (
2626

2727
var (
2828
// GroupVersion is group version used to register these objects
29-
GroupVersion = schema.GroupVersion{Group: "etcd.aenix.io.etcd.aenix.io", Version: "v1alpha1"}
29+
GroupVersion = schema.GroupVersion{Group: "etcd.aenix.io", Version: "v1alpha1"}
3030

3131
// SchemeBuilder is used to add go types to the GroupVersionKind scheme
3232
SchemeBuilder = &scheme.Builder{GroupVersion: GroupVersion}

config/crd/bases/etcd.aenix.io.etcd.aenix.io_etcdclusters.yaml renamed to config/crd/bases/etcd.aenix.io_etcdclusters.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@ kind: CustomResourceDefinition
44
metadata:
55
annotations:
66
controller-gen.kubebuilder.io/version: v0.14.0
7-
name: etcdclusters.etcd.aenix.io.etcd.aenix.io
7+
name: etcdclusters.etcd.aenix.io
88
spec:
9-
group: etcd.aenix.io.etcd.aenix.io
9+
group: etcd.aenix.io
1010
names:
1111
kind: EtcdCluster
1212
listKind: EtcdClusterList

config/crd/kustomization.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
# since it depends on service name and namespace that are out of this kustomize package.
33
# It should be run by config/default
44
resources:
5-
- bases/etcd.aenix.io.etcd.aenix.io_etcdclusters.yaml
5+
- bases/etcd.aenix.io_etcdclusters.yaml
66
#+kubebuilder:scaffold:crdkustomizeresource
77

88
patches:

config/rbac/etcdcluster_editor_role.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ metadata:
1212
name: etcdcluster-editor-role
1313
rules:
1414
- apiGroups:
15-
- etcd.aenix.io.etcd.aenix.io
15+
- etcd.aenix.io
1616
resources:
1717
- etcdclusters
1818
verbs:
@@ -24,7 +24,7 @@ rules:
2424
- update
2525
- watch
2626
- apiGroups:
27-
- etcd.aenix.io.etcd.aenix.io
27+
- etcd.aenix.io
2828
resources:
2929
- etcdclusters/status
3030
verbs:

config/rbac/etcdcluster_viewer_role.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,15 @@ metadata:
1212
name: etcdcluster-viewer-role
1313
rules:
1414
- apiGroups:
15-
- etcd.aenix.io.etcd.aenix.io
15+
- etcd.aenix.io
1616
resources:
1717
- etcdclusters
1818
verbs:
1919
- get
2020
- list
2121
- watch
2222
- apiGroups:
23-
- etcd.aenix.io.etcd.aenix.io
23+
- etcd.aenix.io
2424
resources:
2525
- etcdclusters/status
2626
verbs:

config/rbac/role.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ metadata:
55
name: manager-role
66
rules:
77
- apiGroups:
8-
- etcd.aenix.io.etcd.aenix.io
8+
- etcd.aenix.io
99
resources:
1010
- etcdclusters
1111
verbs:
@@ -17,13 +17,13 @@ rules:
1717
- update
1818
- watch
1919
- apiGroups:
20-
- etcd.aenix.io.etcd.aenix.io
20+
- etcd.aenix.io
2121
resources:
2222
- etcdclusters/finalizers
2323
verbs:
2424
- update
2525
- apiGroups:
26-
- etcd.aenix.io.etcd.aenix.io
26+
- etcd.aenix.io
2727
resources:
2828
- etcdclusters/status
2929
verbs:

config/samples/etcd.aenix.io_v1alpha1_etcdcluster.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
apiVersion: etcd.aenix.io.etcd.aenix.io/v1alpha1
1+
apiVersion: etcd.aenix.io/v1alpha1
22
kind: EtcdCluster
33
metadata:
44
labels:

internal/controller/etcdcluster_controller.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,9 @@ type EtcdClusterReconciler struct {
3333
Scheme *runtime.Scheme
3434
}
3535

36-
//+kubebuilder:rbac:groups=etcd.aenix.io.etcd.aenix.io,resources=etcdclusters,verbs=get;list;watch;create;update;patch;delete
37-
//+kubebuilder:rbac:groups=etcd.aenix.io.etcd.aenix.io,resources=etcdclusters/status,verbs=get;update;patch
38-
//+kubebuilder:rbac:groups=etcd.aenix.io.etcd.aenix.io,resources=etcdclusters/finalizers,verbs=update
36+
//+kubebuilder:rbac:groups=etcd.aenix.io,resources=etcdclusters,verbs=get;list;watch;create;update;patch;delete
37+
//+kubebuilder:rbac:groups=etcd.aenix.io,resources=etcdclusters/status,verbs=get;update;patch
38+
//+kubebuilder:rbac:groups=etcd.aenix.io,resources=etcdclusters/finalizers,verbs=update
3939

4040
// Reconcile is part of the main kubernetes reconciliation loop which aims to
4141
// move the current state of the cluster closer to the desired state.

0 commit comments

Comments
 (0)