Skip to content

Commit b7e51e7

Browse files
authored
Merge pull request #79 from maleck13/client-config
dont fail when missing configmap
2 parents cd716b2 + 38b38dc commit b7e51e7

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

pkg/cmd/clientConfig.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ import (
2222
"github.com/olekukonko/tablewriter"
2323
"github.com/pkg/errors"
2424
"github.com/spf13/cobra"
25+
kerror "k8s.io/apimachinery/pkg/api/errors"
2526
"k8s.io/apimachinery/pkg/apis/meta/v1"
2627
"k8s.io/client-go/kubernetes"
2728
)
@@ -71,7 +72,11 @@ kubectl plugin mobile get clientconfig`,
7172
var svcConfig *ServiceConfig
7273
var err error
7374
configMap, err := ccc.k8Client.CoreV1().ConfigMaps(ns).Get(svc.Name, v1.GetOptions{})
75+
// ignoring not found as some services will not have this public configmap
7476
if err != nil {
77+
if kerror.IsNotFound(err) {
78+
continue
79+
}
7580
return errors.Wrap(err, "unable to create config. Failed to get service "+svc.Name+" configmap")
7681
}
7782
if _, ok := convertors[svc.Name]; !ok {

0 commit comments

Comments
 (0)