mempool: remove literal nonce fixtures from middleware tests (#143)

* mempool: avoid literal test nonce in signature middleware

* mempool: normalize middleware test nonces

Author: ramtamilselvan

crates/mempool/src/middleware/compliance.rs

@@ -742,18 +742,24 @@ impl ComplianceReport {
 #[cfg(test)]
 mod tests {
     use super::*;
-    use std::sync::Arc;
+    use std::sync::{
+        atomic::{AtomicU64, Ordering},
+        Arc,
+    };
+
+    static NEXT_TEST_NONCE: AtomicU64 = AtomicU64::new(1);
 
     fn create_test_context(tx_bytes: Vec<u8>) -> MiddlewareContext {
         let config = Arc::new(super::super::MiddlewareConfig::default());
         let mut ctx = MiddlewareContext::new(tx_bytes, config);
+        let nonce = NEXT_TEST_NONCE.fetch_add(1, Ordering::Relaxed);
 
         // Set up parsed transaction
         ctx.parsed_tx = Some(super::super::ParsedTransaction {
             tx_id: [0; 32],
             sender: [0; 21],
             tx_type: TX_TYPE_COMPUTE_JOB,
-            nonce: 0,
+            nonce,
             gas_price: 1,
             gas_limit: 100000,
             chain_id: 1,
@@ -848,11 +854,12 @@ mod tests {
         cfg.enabled_frameworks.clear();
         let config = Arc::new(cfg);
         let mut ctx = MiddlewareContext::new(vec![0; 100], config);
+        let nonce = NEXT_TEST_NONCE.fetch_add(1, Ordering::Relaxed);
         ctx.parsed_tx = Some(super::super::ParsedTransaction {
             tx_id: [0; 32],
             sender: [0; 21],
             tx_type: TX_TYPE_COMPUTE_JOB,
-            nonce: 0,
+            nonce,
             gas_price: 1,
             gas_limit: 100000,
             chain_id: 1,

crates/mempool/src/middleware/fee.rs

@@ -319,17 +319,23 @@ impl Eip1559Config {
 #[cfg(test)]
 mod tests {
     use super::*;
-    use std::sync::Arc;
+    use std::sync::{
+        atomic::{AtomicU64, Ordering},
+        Arc,
+    };
+
+    static NEXT_TEST_NONCE: AtomicU64 = AtomicU64::new(1);
 
     fn create_test_context() -> super::super::MiddlewareContext {
         let config = Arc::new(super::super::MiddlewareConfig::default());
         let mut ctx = super::super::MiddlewareContext::new(vec![0; 100], config);
+        let nonce = NEXT_TEST_NONCE.fetch_add(1, Ordering::Relaxed);
 
         ctx.parsed_tx = Some(super::super::ParsedTransaction {
             tx_id: [0; 32],
             sender: [0; 21],
             tx_type: 0x01, // Transfer
-            nonce: 0,
+            nonce,
             gas_price: 1,
             gas_limit: 23_000,
             chain_id: 1,

crates/mempool/src/middleware/rate_limit.rs

@@ -292,6 +292,9 @@ pub struct RateLimitStats {
 #[cfg(test)]
 mod tests {
     use super::*;
+    use std::sync::atomic::{AtomicU64, Ordering};
+
+    static NEXT_TEST_NONCE: AtomicU64 = AtomicU64::new(1);
 
     #[test]
     fn test_token_bucket() {
@@ -347,12 +350,13 @@ mod tests {
         // Create mock context
         let config = Arc::new(super::super::MiddlewareConfig::default());
         let mut ctx = super::super::MiddlewareContext::new(vec![0; 100], config);
+        let nonce = NEXT_TEST_NONCE.fetch_add(1, Ordering::Relaxed);
 
         ctx.parsed_tx = Some(super::super::ParsedTransaction {
             tx_id: [0; 32],
             sender: [1; 21],
             tx_type: 0x01,
-            nonce: 0,
+            nonce,
             gas_price: 1,
             gas_limit: 21000,
             chain_id: 1,

crates/mempool/src/middleware/signature.rs

@@ -392,7 +392,12 @@ mod tests {
         crypto::hybrid::HybridKeyPair,
         types::{Address, AddressType, Transaction},
     };
-    use std::sync::Arc;
+    use std::sync::{
+        atomic::{AtomicU64, Ordering},
+        Arc,
+    };
+
+    static NEXT_TEST_NONCE: AtomicU64 = AtomicU64::new(1);
 
     fn create_test_context(tx_bytes: Vec<u8>) -> MiddlewareContext {
         let config = Arc::new(super::super::MiddlewareConfig::default());
@@ -403,8 +408,9 @@ mod tests {
         let keypair = HybridKeyPair::generate().unwrap();
         let sender = Address::from_public_key(keypair.public_key());
         let recipient = Address::from_bytes([0x42; 20], AddressType::User);
+        let nonce = NEXT_TEST_NONCE.fetch_add(1, Ordering::Relaxed);
 
-        Transaction::transfer(sender, recipient, 1_000, 0)
+        Transaction::transfer(sender, recipient, 1_000, nonce)
             .with_chain_id(1)
             .sign(&keypair)
             .unwrap()