Skip to content

setToolTipsVisible is absent tree-wide: every per-action menu tooltip is unreachable #5546

Description

@Ozy311

Summary

QMenu::setToolTipsVisible(true) is called nowhere in the source tree, so every
per-action tooltip in the application is unreachable output. Qt has suppressed per-action
tooltips since 5.1 unless a menu opts in.

#5539 fixes this for TxApplet's two menus, deliberately scoped to the menus #5510 is
about. The same defect remains in seven other files that set a tooltip on a QAction:

  • src/gui/MainWindow_Menus.cpp
  • src/gui/RxApplet.cpp
  • src/gui/VfoWidget.cpp
  • src/gui/WaveformsDialog.cpp
  • src/gui/TciApplet.cpp
  • src/gui/MainWindow.cpp
  • src/gui/Ax25HfPacketDecodeDialog.cpp

Why it is worth doing

The text is already written and already correct. It costs one call per menu to make it
render. Where the action is disabled, the tooltip is usually the only explanation the
operator can get, and a disabled QAction does not highlight on hover either, so the
control reads as broken rather than unavailable. That is exactly how #5510 arrived.

Verified on Qt 6.11.1 that Qt does render tooltips for disabled actions once the menu
opts in, so the fix works for the case that needs it most.

Suggested approach

One menu.setToolTipsVisible(true) per menu construction, matching #5539. Worth a quick
look at each site to confirm the existing tooltip text still reads correctly now that it
will actually be seen; some may have been written as code comments in spirit.

Happy to do this as a follow-up PR if wanted.


73, Ozy K6OZY - model: claude-opus-5

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    GUIUser interfacebugSomething isn't workinggood first issueGood for newcomersmaintainer-reviewRequires maintainer review before any action is taken

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions