Summary
QMenu::setToolTipsVisible(true) is called nowhere in the source tree, so every
per-action tooltip in the application is unreachable output. Qt has suppressed per-action
tooltips since 5.1 unless a menu opts in.
#5539 fixes this for TxApplet's two menus, deliberately scoped to the menus #5510 is
about. The same defect remains in seven other files that set a tooltip on a QAction:
src/gui/MainWindow_Menus.cpp
src/gui/RxApplet.cpp
src/gui/VfoWidget.cpp
src/gui/WaveformsDialog.cpp
src/gui/TciApplet.cpp
src/gui/MainWindow.cpp
src/gui/Ax25HfPacketDecodeDialog.cpp
Why it is worth doing
The text is already written and already correct. It costs one call per menu to make it
render. Where the action is disabled, the tooltip is usually the only explanation the
operator can get, and a disabled QAction does not highlight on hover either, so the
control reads as broken rather than unavailable. That is exactly how #5510 arrived.
Verified on Qt 6.11.1 that Qt does render tooltips for disabled actions once the menu
opts in, so the fix works for the case that needs it most.
Suggested approach
One menu.setToolTipsVisible(true) per menu construction, matching #5539. Worth a quick
look at each site to confirm the existing tooltip text still reads correctly now that it
will actually be seen; some may have been written as code comments in spirit.
Happy to do this as a follow-up PR if wanted.
73, Ozy K6OZY - model: claude-opus-5
Summary
QMenu::setToolTipsVisible(true)is called nowhere in the source tree, so everyper-action tooltip in the application is unreachable output. Qt has suppressed per-action
tooltips since 5.1 unless a menu opts in.
#5539 fixes this for
TxApplet's two menus, deliberately scoped to the menus #5510 isabout. The same defect remains in seven other files that set a tooltip on a
QAction:src/gui/MainWindow_Menus.cppsrc/gui/RxApplet.cppsrc/gui/VfoWidget.cppsrc/gui/WaveformsDialog.cppsrc/gui/TciApplet.cppsrc/gui/MainWindow.cppsrc/gui/Ax25HfPacketDecodeDialog.cppWhy it is worth doing
The text is already written and already correct. It costs one call per menu to make it
render. Where the action is disabled, the tooltip is usually the only explanation the
operator can get, and a disabled
QActiondoes not highlight on hover either, so thecontrol reads as broken rather than unavailable. That is exactly how #5510 arrived.
Verified on Qt 6.11.1 that Qt does render tooltips for disabled actions once the menu
opts in, so the fix works for the case that needs it most.
Suggested approach
One
menu.setToolTipsVisible(true)per menu construction, matching #5539. Worth a quicklook at each site to confirm the existing tooltip text still reads correctly now that it
will actually be seen; some may have been written as code comments in spirit.
Happy to do this as a follow-up PR if wanted.
73, Ozy K6OZY - model: claude-opus-5