CI: change the endpoint from localhost to the IP of the running samba service

Author: afiffon

.github/workflows/rust.yml .github/workflows/build.yml.github/workflows/rust.yml renamed to .github/workflows/build.yml

@@ -1,4 +1,4 @@
-name: Rust
+name: Build
 
 on:
   push:
@@ -12,9 +12,12 @@ env:
   CARGO_TERM_COLOR: always
 
 jobs:
-  build_and_test:
+  test:
 
     runs-on: ubuntu-latest
+    container: 
+      image: rust:latest
+
     strategy:
       matrix:
         compile_features: [ async, multi_threaded, single_threaded ]
@@ -31,10 +34,24 @@ jobs:
         credentials:
           username: ${{ github.actor }}
           password: ${{ secrets.ACCESS_TOKEN }}
+        options: --name samba --privileged --cap-add NET_ADMIN
 
     steps:
     - uses: actions/checkout@v4
+    - name: check
+      run: |
+        apt update
+        apt install -y iputils-ping net-tools netcat-traditional samba smbclient tcpdump
+        ping -c 4 samba
+        nc -zv samba 445
+        find / -name smbclient
+        echo "ls" | smbclient --user=LocalAdmin --password=123456 "\\\\samba\\MyShare"
     - name: Build/${{ matrix.compile_features }}
       run: cargo build --verbose --no-default-features --features "${{ matrix.compile_features }},sign,encrypt,compress"
     - name: Tests/${{ matrix.compile_features }}
-      run: cargo test --verbose --no-default-features --features "${{ matrix.compile_features }},sign,encrypt,compress"
+      run: |
+        export SMB_RUST_TESTS_SERVER=samba:445
+        echo "ls" | smbclient --debuglevel=10 --user=LocalAdmin --password=123456 "\\\\samba\\MyShare"
+        # run tcpdump in background to capture SMB traffic, log to stdout
+        tcpdump -i any -w - -s 0 -nn -vv -X -c 100 'port 445' &
+        cargo test --verbose --no-default-features --features "${{ matrix.compile_features }},sign,encrypt,compress" -- --nocapture

smb/tests/README.md

@@ -0,0 +1,14 @@
+# Integration tests
+## Running the tests
+The tests below are intended to test the library's integration with the SMB protocol, by starting up a samba container and running the tests against it.
+To start the container, run the following command:
+```bash
+docker compose up [-d]
+```
+
+Then, you can run the tests as usual, using `cargo test`.
+
+> [!IMPORTANT]
+> The tests bind to port 445 by default, so make sure it is available on your machine.
+> On many windows machines, this port is already in use by the system; Modify docker-compose.yml to use a different port if necessary,
+> and use the `SMB_RUST_TESTS_SERVER=HOST:PORT` environment variable to specify the new port. The same goes for the IP address, if necessary.

smb/tests/smb_integration_tests.rs smb/tests/integration_tests.rssmb/tests/smb_integration_tests.rs renamed to smb/tests/integration_tests.rs

@@ -13,13 +13,19 @@ pub async fn test_smb_integration_basic() -> Result<(), Box<dyn std::error::Erro
 
     let mut smb = Connection::new();
     // Default to localhost, LocalAdmin, 123456
-    let server = var("SMB_SERVER").unwrap_or("127.0.0.1:445".to_string());
-    let user = var("SMB_USER").unwrap_or("LocalAdmin".to_string());
-    let password = var("SMB_PASSWORD").unwrap_or("123456".to_string());
+    let server = var("SMB_RUST_TESTS_SERVER").unwrap_or("127.0.0.1:445".to_string());
+    let user = var("SMB_RUST_TESTS_USER_NAME").unwrap_or("LocalAdmin".to_string());
+    let password = var("SMB_RUST_TESTS_PASSWORD").unwrap_or("123456".to_string());
+
+    println!("Connecting to {} as {}", server, user);
+
     // Connect & Authenticate
     smb.connect(&server).await?;
+    print!("Connected, authenticating...");
     let mut session = smb.authenticate(&user, password).await?;
+    println!("Authenticated!");
     let mut tree = session.tree_connect("MyShare").await?;
+    print!("Connected to share, start test basic");
 
     // Hello, World! > test.txt
     {