Does the multi_threaded feature use its own runtime?

[phughesion-h3]

Trying to use this library within a multi threaded tokio runtime. I see that with just the async feature, session::authenticator::GssAuthTokenHandler is not Send. Enabling the multithreaded feature works but removes the ability to await, so does this happen automatically internally?

[afiffon]

Generally, I'd point out that the main purpose of supporting multi-threading/async is to allow parallelizing SMB requests to improve throughput of reading/writing files (despite this is still being a work in progress, regarding the performance), so it is possible that Connection/Session/other structures are not yet Send, but let me add this as a TODO so it can be supported (since I think it's not a big deal).

[afiffon]

@phughesion-h3 What structure exactly are you trying to send? Because it seems like this is an internal structure, that is only used when authenticating the user (in GssAuthenticator::build).
I see that, for example, Connection is Send.

[phughesion-h3]

I have a task that is specific to SMB functionality so I would like to be able to instantiate the client/connection within a tokio::spawn block.

It looks like I can use the connection, once established, in a spawn block, but creating the connection itself cannot be inside of a spawned task.

The following example works, but if the let (client, session, tree) line is put within set.spawn, it doesn't compile.

                           
      let (client, _session, _tree) = opts.address.connect(
          &opts.username,
          opts.password.clone(),
          opts.port,
      ).await.unwrap();

      set.spawn(async move {
          // connection.whatever...
      });

[afiffon]

@phughesion-h3 I'm checking it out for you

[afiffon]

@phughesion-h3 I have just released a minor version of the crate: https://github.com/AvivNaaman/smb-rs/releases/tag/v0.4.2
you can update your crate's dependency to the newest version, and you should be good to go!