refactor: improve Discord API usage and method call idioms

Author: afonsojramos

Cargo.lock

@@ -37,8 +37,8 @@ tray-icon = "0.19"
 ksni = { version = "0.3", features = ["blocking"] }
 
 [target.'cfg(target_os = "macos")'.dependencies]
-objc2-app-kit = "0.2"
-objc2-foundation = "0.2"
+objc2-app-kit = "0.3"
+objc2-foundation = "0.3"
 
 [target.'cfg(target_os = "windows")'.build-dependencies]
 winresource = "0.1.28"

Cargo.toml

@@ -28,10 +28,6 @@ pub struct Payload {
 }
 
 impl Discord {
-    /// Creates a new Discord client with the given application ID.
-    ///
-    /// Note: discord-rich-presence 1.0.0 changed the API - `DiscordIpcClient::new()`
-    /// now returns the client directly (not a Result).
     pub fn new(discord_client_id: String) -> Discord {
         Discord {
             client: DiscordIpcClient::new(&discord_client_id),
@@ -40,10 +36,9 @@ impl Discord {
     }
 
     /// Switch to a different Discord application ID if needed.
-    /// Returns true if a switch occurred.
-    fn switch_app_id(&mut self, new_app_id: &str) -> bool {
+    fn switch_app_id(&mut self, new_app_id: &str) {
         if self.current_app_id == new_app_id {
-            return false;
+            return;
         }
 
         tracing::info!(
@@ -56,11 +51,9 @@ impl Discord {
         let _ = self.client.close();
 
         // Create new client with new app ID
-        // Note: discord-rich-presence 1.0.0 - new() no longer returns Result
         self.client = DiscordIpcClient::new(new_app_id);
         self.current_app_id = new_app_id.to_string();
         self.connect();
-        true
     }
 
     pub fn connect(&mut self) {

src/discord.rs

@@ -121,11 +121,10 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
 
     // Spawn background polling thread
     let polling_handle = thread::spawn(move || {
-        // discord-rich-presence 1.0.0: new() no longer returns Result
         let mut discord = Discord::new(DEFAULT_DISCORD_APP_ID.to_string());
         let mut trakt = Trakt::new(trakt_client_id, trakt_username, trakt_access_token);
 
-        Discord::connect(&mut discord);
+        discord.connect();
 
         // Update state: Discord connected
         if let Ok(mut state) = app_state_clone.write() {
@@ -149,7 +148,7 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
             let is_paused = app_state_clone.read().map(|s| s.is_paused).unwrap_or(false);
 
             if is_paused {
-                Discord::close(&mut discord);
+                discord.close();
                 continue;
             }
 
@@ -161,7 +160,7 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
                     if let Ok(mut state) = app_state_clone.write() {
                         state.clear_watching();
                     }
-                    Discord::close(&mut discord);
+                    discord.close();
                     continue;
                 }
             };
@@ -193,10 +192,10 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
                 state.set_watching(title, details, watch_stats.watch_percentage);
             }
 
-            Discord::set_activity(&mut discord, &response, &mut trakt, tmdb_token.clone());
+            discord.set_activity(&response, &mut trakt, tmdb_token.clone());
         }
 
-        Discord::close(&mut discord);
+        discord.close();
         tracing::info!("Polling thread stopped");
     });