fix review comments

Author: aganesh-suse

modules/install/join_k3s_agent.sh

@@ -2,7 +2,7 @@
 # Usage:
 # node_os=${1} # Node OS values. Ex: rhel8, centos8, slemicro
 # server_ip=${2} # Master Server IP to join to. Value will be added to config.yaml file.
-# token=${3} # Node Token
+# token=${3} # Node Token. Value will be added to config.yaml file.
 # public_ip=${4} # Public IP of the agent node. Value will be added to config.yaml file.
 # private_ip=${5} # Private IP of the agent node. Value will be added to config.yaml file.
 # ipv6_ip=${6} # IPv6 IP of the agent node. Value will be added to config.yaml file.

modules/install/join_k3s_master.sh

@@ -1,17 +1,17 @@
 #!/bin/bash
 # Usage:
 # node_os=${1} # Node OS values. Ex: rhel8, centos8, slemicro
-# fqdn=${2} # FQDN
+# fqdn=${2} # FQDN. Value will be added to config.yaml file.
 # server_ip=${3} # # Master Server IP to join to. Value will be added to config.yaml file.
-# token=${4} # Node Token
-# public_ip=${5} # Public IP of the joining server node
-# private_ip=${6} # Privaate IP of the joining server node
-# ipv6_ip=${7} # IPV6 IP of the joining server node
+# token=${4} # Node Token. Value will be added to config.yaml file.
+# public_ip=${5} # Public IP of the joining server node. Value will be added to config.yaml file.
+# private_ip=${6} # Privaate IP of the joining server node. Value will be added to config.yaml file.
+# ipv6_ip=${7} # IPV6 IP of the joining server node. Value will be added to config.yaml file.
 # install_mode=${8} # Install mode - INSTALL_<K3S|RKE2>_<VERSION|COMMIT>
 # version=${9} # Version or Commit to install
 # channel=${10} # Channel to install from - values can be testing, latest or stable
 # datastore_type=${11} # Datastore type can be etcd or external
-# datastore_endpoint=${12} # Datastore endpoint
+# datastore_endpoint=${12} # Datastore endpoint. Value will be added to config.yaml file.
 # server_flags=${13} # Server Flags to add in config.yaml
 # rhel_username=${14} # rhel username
 # rhel_password=${15} # rhel Password

modules/install/join_rke2_agent.sh

@@ -3,10 +3,10 @@
 # Usage:
 # node_os=${1} # Node OS values. Ex: rhel8, centos8, slemicro
 # server_ip=${2} # Master Server IP to join to. Value will be added to config.yaml file.
-# token=${3} # Node Token
-# public_ip=${4} # Public IP of the agent node
-# private_ip=${5} # Private IP of the agent node
-# ipv6_ip=${6} # IPv6 IP of the agent node
+# token=${3} # Node Token. Value will be added to config.yaml file.
+# public_ip=${4} # Public IP of the agent node. Value will be added to config.yaml file.
+# private_ip=${5} # Private IP of the agent node. Value will be added to config.yaml file.
+# ipv6_ip=${6} # IPv6 IP of the agent node. Value will be added to config.yaml file.
 # install_mode=${7} # Install mode - INSTALL_<K3S|RKE2>_<VERSION|COMMIT>
 # version=${8} # Version or Commit to install
 # channel=${9} # Channel to install from - testing, latest or stable

modules/install/join_rke2_master.sh

@@ -2,18 +2,18 @@
 # This script is used to join one or more nodes as servers to the first server
 # Usage:
 # node_os=${1} # Node OS values. Ex: rhel8, centos8, slemicro
-# fqdn=${2} # FQDN
+# fqdn=${2} # FQDN. Value will be added to config.yaml file.
 # server_ip=${3} # Master Server IP to join to. Value will be added to config.yaml file.
-# token=${4} # Node Token
-# public_ip=${5} # Public IP of the joining server node
-# private_ip=${6} # Private IP of the joining server node
-# ipv6_ip=${7} # IPv6 IP of the joining server node
+# token=${4} # Node Token. Value will be added to config.yaml file.
+# public_ip=${5} # Public IP of the joining server node. Value will be added to config.yaml file.
+# private_ip=${6} # Private IP of the joining server node. Value will be added to config.yaml file.
+# ipv6_ip=${7} # IPv6 IP of the joining server node. Value will be added to config.yaml file.
 # install_mode=${8} # Install mode - INSTALL_<K3S|RKE2>_<VERSION|COMMIT>
 # version=${9} # Version or Commit to Install
 # channel=${10} # Channel to install from - testing latest or stable
 # install_method=${11} # Method of install - rpm or tar
 # datastore_type=${12} # Datastore type - etcd or external
-# datastore_endpoint=${13} # Datastore Endpoint
+# datastore_endpoint=${13} # Datastore Endpoint. Value will be added to config.yaml file.
 # server_flags=${14} # Server Flags to add in config.yaml
 # rhel_username=${15} # rhel username
 # rhel_password=${16} # rhel password

modules/install/k3s_master.sh

@@ -1,16 +1,16 @@
 #!/bin/bash
 # Usage:
 # node_os=${1} # Node OS values. Ex: rhel8, centos8, slemicro
-# fqdn=${2} # FQDN Value
-# public_ip=${3} # Public IP of the master server node
-# private_ip=${4} # Private IP of the master server node
-# ipv6_ip=${5} # IPv6 IP of the master server node
+# fqdn=${2} # FQDN Value. Value will be added to config.yaml file.
+# public_ip=${3} # Public IP of the master server node. Value will be added to config.yaml file.
+# private_ip=${4} # Private IP of the master server node. Value will be added to config.yaml file.
+# ipv6_ip=${5} # IPv6 IP of the master server node. Value will be added to config.yaml file.
 # install_mode=${6} # Install mode - INSTALL_<K3S|RKE2>_<VERSION|COMMIT>
 # version=${7} # Version or Commit to install
 # channel=${8} # Channel values can be testing, latest or stable.
 # etcd_only_node=${9} # Count of etcd only nodes
 # datastore_type=${10} # Datastore type: etcd or external
-# datastore_endpoint=${11} # Datastore endpoint
+# datastore_endpoint=${11} # Datastore endpoint. Value will be added to config.yaml file.
 # server_flags=${12} # Server Flags to use in config.yaml
 # rhel_username=${13} # rhel username
 # rhel_password=${14} # rhel password

modules/install/rke2_master.sh

@@ -3,18 +3,18 @@
 # and ready before proceeding to install other nodes
 # Usage:
 # node_os=${1} # Node OS values. Ex: rhel8, centos8, slemicro
-# fqdn=${2} # FQDN Value
-# public_ip=${3} # Public IP of the master server node
-# private_ip=${4} # Private IP of the master server node
-# ipv6_ip=${5} # IPv6 of the master node
+# fqdn=${2} # FQDN Value. Value will be added to config.yaml file.
+# public_ip=${3} # Public IP of the master server node. Value will be added to config.yaml file.
+# private_ip=${4} # Private IP of the master server node. Value will be added to config.yaml file.
+# ipv6_ip=${5} # IPv6 of the master node. Value will be added to config.yaml file.
 # install_mode=${6} # Install mode - INSTALL_<K3S|RKE2>_<VERSION|COMMIT>
 # version=${7} # Version or Commit to install
 # channel=${8} # Channel to install from - values can be: testing, latest, stable
 # install_method=${9} # Install Method can be rpm or tar
 # datastore_type=${10} # Datastore type: etcd or external
-# datastore_endpoint=${11} # Datastore endpoint
+# datastore_endpoint=${11} # Datastore endpoint. Value will be added to config.yaml file.
 # server_flags=${12} # Server Flags to add in config.yaml
-# rhel_username=${13} # rhel Username
+# rhel_username=${13} # rhel username
 # rhel_password=${14} # rhel password
 # install_or_enable=${15} # Values can be install, enable or both. In case of slemicro for node_os value, the first time this script is called with 'install'.
 # After a node reboot, the second time the script is recalled with 'enable' which enables services.