Skip to content

Commit 8dcb628

Browse files
Copilotandreasabel
andcommitted
Address review comments from PR #1
Co-authored-by: andreasabel <[email protected]>
1 parent 322b4db commit 8dcb628

File tree

3 files changed

+25
-66
lines changed

3 files changed

+25
-66
lines changed

.github/workflows/example.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111

1212
steps:
1313
- name: Checkout repository
14-
uses: actions/checkout@v4
14+
uses: actions/checkout@v5
1515

1616
- name: Setup Agda
1717
id: setup-agda
@@ -31,8 +31,8 @@ jobs:
3131
cat > Example.agda << 'EOF'
3232
module Example where
3333
34-
open import Data.Bool
35-
open import Data.Nat
34+
open import Data.Bool.Base
35+
open import Data.Nat.Base
3636
3737
example : Bool
3838
example = true

.github/workflows/test.yml

Lines changed: 18 additions & 59 deletions
Original file line numberDiff line numberDiff line change
@@ -13,18 +13,30 @@ permissions:
1313
contents: read
1414

1515
jobs:
16-
test-linux:
17-
runs-on: ubuntu-latest
16+
test:
17+
strategy:
18+
matrix:
19+
os: [ubuntu-latest, windows-latest, macos-latest, macos-13]
20+
include:
21+
- os: ubuntu-latest
22+
agda-stdlib-version: '2.3'
23+
- os: windows-latest
24+
agda-stdlib-version: ''
25+
- os: macos-latest
26+
agda-stdlib-version: '2.3'
27+
- os: macos-13
28+
agda-stdlib-version: ''
29+
runs-on: ${{ matrix.os }}
1830
steps:
1931
- name: Checkout
20-
uses: actions/checkout@v4
32+
uses: actions/checkout@v5
2133

2234
- name: Setup Agda
2335
id: setup
2436
uses: ./
2537
with:
2638
agda-version: '2.8.0'
27-
agda-stdlib-version: '2.3'
39+
agda-stdlib-version: ${{ matrix.agda-stdlib-version }}
2840

2941
- name: Verify Agda installation
3042
run: |
@@ -33,6 +45,7 @@ jobs:
3345
agda --version
3446
3547
- name: Create test file
48+
if: matrix.os == 'ubuntu-latest'
3649
run: |
3750
cat > test.agda << 'EOF'
3851
module test where
@@ -42,59 +55,5 @@ jobs:
4255
EOF
4356
4457
- name: Test Agda
58+
if: matrix.os == 'ubuntu-latest'
4559
run: agda test.agda
46-
47-
test-windows:
48-
runs-on: windows-latest
49-
steps:
50-
- name: Checkout
51-
uses: actions/checkout@v4
52-
53-
- name: Setup Agda
54-
id: setup
55-
uses: ./
56-
with:
57-
agda-version: '2.8.0'
58-
59-
- name: Verify Agda installation
60-
run: |
61-
echo "Agda path: ${{ steps.setup.outputs.agda-path }}"
62-
echo "Agda dir: ${{ steps.setup.outputs.agda-dir }}"
63-
agda --version
64-
65-
test-macos:
66-
runs-on: macos-latest
67-
steps:
68-
- name: Checkout
69-
uses: actions/checkout@v4
70-
71-
- name: Setup Agda
72-
id: setup
73-
uses: ./
74-
with:
75-
agda-version: '2.8.0'
76-
agda-stdlib-version: '2.3'
77-
78-
- name: Verify Agda installation
79-
run: |
80-
echo "Agda path: ${{ steps.setup.outputs.agda-path }}"
81-
echo "Agda dir: ${{ steps.setup.outputs.agda-dir }}"
82-
agda --version
83-
84-
test-macos-intel:
85-
runs-on: macos-13 # Intel-based macOS
86-
steps:
87-
- name: Checkout
88-
uses: actions/checkout@v4
89-
90-
- name: Setup Agda
91-
id: setup
92-
uses: ./
93-
with:
94-
agda-version: '2.8.0'
95-
96-
- name: Verify Agda installation
97-
run: |
98-
echo "Agda path: ${{ steps.setup.outputs.agda-path }}"
99-
echo "Agda dir: ${{ steps.setup.outputs.agda-dir }}"
100-
agda --version

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,13 @@ GitHub composite action to install Agda from the official deployed binaries and
44

55
## Features
66

7-
- Installs Agda from official GitHub releases
8-
- Optional installation of the Agda standard library
7+
- Installs Agda from official GitHub releases.
8+
- Optional installation of the Agda standard library.
99
- Cross-platform support:
1010
- Ubuntu (latest)
1111
- Windows (latest)
1212
- macOS (latest, including macOS-15-intel)
13-
- Outputs the path to the Agda executable and Agda application directory
13+
- Outputs the path to the Agda executable and Agda application directory.
1414

1515
## Usage
1616

@@ -76,7 +76,7 @@ jobs:
7676
runs-on: ubuntu-latest
7777
7878
steps:
79-
- uses: actions/checkout@v4
79+
- uses: actions/checkout@v5
8080
8181
- name: Setup Agda
8282
uses: agda/agda-setup-action@v1

0 commit comments

Comments
 (0)