Revert "Add region to lambda function name to prevent name collision"

LouisBoudreau · LouisBoudreau · commit 40756c9f30c7 · 2023-02-16T15:14:18.000-05:00
This reverts commit 1872ccd.
diff --git a/terraform/main.tf b/terraform/main.tf
@@ -3,7 +3,7 @@ locals {
 }
 
 resource "aws_lambda_function" "lambda" {
-  function_name    = "route53-event-forwarder-${data.aws_region.current.name}"
+  function_name    = "route53-event-forwarder"
   filename         = local.lambda_zip
   source_code_hash = filebase64sha256(local.lambda_zip)
   handler          = "index.handler"
@@ -18,7 +18,7 @@ resource "aws_lambda_function" "lambda" {
     }
   }
 
-  dynamic "dead_letter_config" {
+  dynamic dead_letter_config {
     for_each = var.sns_topic_to_notify_on_failure != null ? [var.sns_topic_to_notify_on_failure] : []
     iterator = sns_topic_arn
     content {

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@ locals {`
`3`	`3`	`}`
`4`	`4`
`5`	`5`	`resource "aws_lambda_function" "lambda" {`
`6`		`- function_name = "route53-event-forwarder-${data.aws_region.current.name}"`
	`6`	`+ function_name = "route53-event-forwarder"`
`7`	`7`	`filename = local.lambda_zip`
`8`	`8`	`source_code_hash = filebase64sha256(local.lambda_zip)`
`9`	`9`	`handler = "index.handler"`
`@@ -18,7 +18,7 @@ resource "aws_lambda_function" "lambda" {`
`18`	`18`	`}`
`19`	`19`	`}`
`20`	`20`
`21`		`- dynamic "dead_letter_config" {`
	`21`	`+ dynamic dead_letter_config {`
`22`	`22`	`for_each = var.sns_topic_to_notify_on_failure != null ? [var.sns_topic_to_notify_on_failure] : []`
`23`	`23`	`iterator = sns_topic_arn`
`24`	`24`	`content {`