refactor(tests): remove unused variables in test files

Address Copilot review feedback:
- Remove unused 'name' in CLI_TOOLS iteration
- Use more descriptive variable names in cache refresh test
- Remove unused multiPassFindings and mediumFindings variables

Author: avifenesh

__tests__/cli-enhancers.test.js

@@ -76,7 +76,7 @@ describe('cli-enhancers', () => {
     });
 
     it('each tool should have required fields', () => {
-      for (const [name, tool] of Object.entries(CLI_TOOLS)) {
+      for (const tool of Object.values(CLI_TOOLS)) {
         expect(tool.name).toBeDefined();
         expect(tool.description).toBeDefined();
         expect(tool.checkCommand).toBeDefined();
@@ -309,14 +309,15 @@ describe('cli-enhancers', () => {
 
     it('should refresh cache when forceRefresh is true', () => {
       fs.writeFileSync(path.join(tempDir, 'package.json'), '{}');
-      const result1 = getToolAvailabilityForRepo(tempDir);
+      getToolAvailabilityForRepo(tempDir); // Initial cache
       // Add Python
       fs.writeFileSync(path.join(tempDir, 'requirements.txt'), 'flask\n');
-      // Without force refresh, should still show only JS
-      const result2 = getToolAvailabilityForRepo(tempDir);
+      // Without force refresh, should still show only JS (cached)
+      const cachedResult = getToolAvailabilityForRepo(tempDir);
+      expect(cachedResult.languages).not.toContain('python');
       // With force refresh, should detect Python too
-      const result3 = getToolAvailabilityForRepo(tempDir, { forceRefresh: true });
-      expect(result3.languages).toContain('python');
+      const refreshedResult = getToolAvailabilityForRepo(tempDir, { forceRefresh: true });
+      expect(refreshedResult.languages).toContain('python');
     });
   });
 

__tests__/pipeline.test.js

@@ -446,10 +446,9 @@ function foo() {
         targetFiles: ['test.js']
       });
 
-      // Normal mode includes multi-pass analyzers
-      const multiPassFindings = result.findings.filter(f => f.certainty === CERTAINTY.MEDIUM);
-      // May or may not have findings depending on thresholds
+      // Normal mode includes multi-pass analyzers (may or may not have findings depending on thresholds)
       expect(result.findings).toBeDefined();
+      expect(result.metadata.thoroughness).toBe('normal');
     });
 
     it('should track missing tools in deep mode', () => {
@@ -609,10 +608,10 @@ function foo() {
         targetFiles: ['test.js']
       });
 
-      // Should have MEDIUM certainty findings from multi-pass
-      const mediumFindings = result.findings.filter(f => f.certainty === CERTAINTY.MEDIUM);
-      // The doc_code_ratio should detect the excessive JSDoc
-      expect(result.findings.length).toBeGreaterThanOrEqual(0);
+      // Should run multi-pass analyzers which may produce MEDIUM certainty findings
+      // The doc_code_ratio analyzer may detect the excessive JSDoc if it meets thresholds
+      expect(result.findings).toBeDefined();
+      expect(result.metadata.thoroughness).toBe('normal');
     });
 
     it('deep mode should track missing CLI tools', () => {