fix: address PR review feedback (Copilot + Gemini)

Round-up of 8 unresolved threads on PR #346.

Test stability (Copilot ×2)
- __tests__/cli-subcommands.test.js: derive expected count from
  loadMarketplace().plugins.length and assert anchor plugins are
  present. Old hardcoded '20 plugin(s) found' / 'with 20 plugins' was
  destined to break on every marketplace addition.

Generator parity (Copilot, Gemini HIGH)
- scripts/generate-docs.js: generateAgentCounts now uses static
  fallbacks when local discovery is empty (post-graduation reality).
  Auto-gen block in docs/reference/AGENTS.md now reports
  '49 agents across 20 plugins (18 have agents)' instead of the
  meaningless '10 agents across 0 plugins'.
- __tests__/generate-docs.test.js: tests track the same fallback.

Count accuracy across docs (Copilot, Gemini MEDIUM)
- AGENTS.md, docs/reference/AGENTS.md: prose now says
  '49 agents across 20 plugins (18 have agents)'. Earlier '47 / 17'
  prose was a pre-existing inaccuracy that this PR quietly corrects -
  ship has 1 agent (release-agent.md) so it belongs in the
  'have agents' bucket; only gate-and-ship and zig-lsp don't.
- docs/reference/AGENTS.md L36: file-based agent count 37 -> 39
  (matches sum of STATIC_PLUGIN_AGENT_COUNTS).
- site/index.html L752: 'Skills across 20 Plugins' -> '19 Plugins'.
  zig-lsp contributes 0 skills, so the count of skill-contributing
  plugins is unchanged. Reverting Gemini's flagged inaccuracy.
- docs/ARCHITECTURE.md L277: sync-pipeline language softened to
  '19 plugin repos today; zig-lsp sync wire-up pending', matching
  the open checkbox in docs/ORG_ARCHITECTURE.md.
- site/ux-spec.md L231: pre-existing typo Skills=40 -> 41.

PR description has stale 'deliberately not updated: generate-docs.js'
- will update separately as a PR comment once these land.

Author: avifenesh

AGENTS.md

@@ -152,7 +152,7 @@ agentsys                # Run installer
 <agents>
 ## Agents
 
-47 agents across 20 plugins (zig-lsp ships as a config-only LSP plugin with no agents). Key agents by model:
+49 agents across 20 plugins (18 have agents; gate-and-ship is commands-only; zig-lsp is config-only with no commands or agents). Key agents by model:
 
 | Model | Agents | Use Case |
 |-------|--------|----------|

__tests__/cli-subcommands.test.js

@@ -107,7 +107,11 @@ describe('searchPlugins', () => {
     const output = logOutput.join('\n');
     expect(output).toContain('next-task');
     expect(output).toContain('deslop');
-    expect(output).toContain('20 plugin(s) found');
+    // Count derived from marketplace.json so this test stays stable as
+    // the marketplace grows. Asserts the suffix and uses the same
+    // source-of-truth the production code reads.
+    const expectedCount = loadMarketplace().plugins.length;
+    expect(output).toContain(`${expectedCount} plugin(s) found`);
   });
 
   test('filters by name', () => {
@@ -366,10 +370,17 @@ describe('granular install recording', () => {
 });
 
 describe('loadMarketplace', () => {
-  test('loads marketplace.json with 20 plugins', () => {
+  test('loads marketplace.json with at least one plugin including the canonical core set', () => {
     const marketplace = loadMarketplace();
     expect(marketplace.plugins).toBeDefined();
-    expect(marketplace.plugins.length).toBe(20);
+    expect(marketplace.plugins.length).toBeGreaterThan(0);
+    // Spot-check a few plugins that anchor the marketplace identity.
+    // These are unlikely to ever be removed - if any of them is, the
+    // change deserves an explicit, visible test update.
+    const names = marketplace.plugins.map(p => p.name);
+    for (const required of ['next-task', 'ship', 'agnix']) {
+      expect(names).toContain(required);
+    }
   });
 
   test('all plugins have name, source, version', () => {

__tests__/generate-docs.test.js

@@ -166,20 +166,28 @@ describe('generate-docs', () => {
   });
 
   describe('generateAgentCounts', () => {
+    // Mirrors the production fallback in generateAgentCounts: when local
+    // discovery is empty (post-graduation, plugins live in standalone repos)
+    // the function reports the canonical project-wide STATIC_AGENT_COUNT
+    // instead of just the locally-discoverable agents.
+    function expectedTotalAgents(agents) {
+      return agents.length > 0
+        ? agents.length + genDocs.ROLE_BASED_AGENT_COUNT
+        : genDocs.STATIC_AGENT_COUNT;
+    }
+
     test('includes total agent count', () => {
       const agents = discovery.discoverAgents(REPO_ROOT);
       const plugins = discovery.discoverPlugins(REPO_ROOT);
       const counts = genDocs.generateAgentCounts(agents, plugins);
-      const totalAgents = agents.length + genDocs.ROLE_BASED_AGENT_COUNT;
-      expect(counts).toContain(`${totalAgents} agents`);
+      expect(counts).toContain(`${expectedTotalAgents(agents)} agents`);
     });
 
     test('includes AGENT_COUNT_TOTAL comment', () => {
       const agents = discovery.discoverAgents(REPO_ROOT);
       const plugins = discovery.discoverPlugins(REPO_ROOT);
       const counts = genDocs.generateAgentCounts(agents, plugins);
-      const totalAgents = agents.length + genDocs.ROLE_BASED_AGENT_COUNT;
-      expect(counts).toContain(`<!-- AGENT_COUNT_TOTAL: ${totalAgents} -->`);
+      expect(counts).toContain(`<!-- AGENT_COUNT_TOTAL: ${expectedTotalAgents(agents)} -->`);
     });
 
     test('counts plugins with agents correctly', () => {

docs/ARCHITECTURE.md

@@ -275,7 +275,7 @@ Research documents informing the implementation (in `agent-docs/`):
 
 **Update workflow:**
 1. Edit files in `lib/` (canonical source in this repo)
-2. Push to main — agent-core sync pipeline automatically opens PRs in all 20 plugin repos
+2. Push to main — agent-core sync pipeline automatically opens PRs in 19 plugin repos today (`zig-lsp` sync wire-up still pending; tracked in docs/ORG_ARCHITECTURE.md)
 3. Merge those PRs in each plugin repo
 4. Publish agentsys: `npm version patch && npm publish`
 

docs/reference/AGENTS.md

@@ -3,7 +3,7 @@
 Complete reference for all agents in AgentSys.
 
 <!-- GEN:START:agents-counts -->
-**TL;DR:** 10 agents across 0 plugins (1 have agents). opus for reasoning, sonnet for patterns, haiku for execution. Each agent does one thing well. <!-- AGENT_COUNT_TOTAL: 10 -->
+**TL;DR:** 49 agents across 20 plugins (18 have agents). opus for reasoning, sonnet for patterns, haiku for execution. Each agent does one thing well. <!-- AGENT_COUNT_TOTAL: 49 -->
 <!-- GEN:END:agents-counts -->
 
 ---
@@ -24,7 +24,7 @@ Complete reference for all agents in AgentSys.
 
 ## Overview
 
-AgentSys uses 47 specialized agents across 20 plugins (17 have agents; ship and gate-and-ship are commands-only; zig-lsp is a config-only LSP plugin with no commands or agents). Each agent is optimized for a specific task and assigned a model based on complexity:
+AgentSys uses 49 specialized agents across 20 plugins (18 have agents; gate-and-ship is commands-only; zig-lsp is a config-only LSP plugin with no commands or agents). Each agent is optimized for a specific task and assigned a model based on complexity:
 
 | Model | Use Case | Cost |
 |-------|----------|------|
@@ -33,7 +33,7 @@ AgentSys uses 47 specialized agents across 20 plugins (17 have agents; ship and
 | haiku | Mechanical execution, no judgment | Low |
 
 **Agent types:**
-- **File-based agents** (37) - Defined in `plugins/*/agents/*.md` with frontmatter <!-- AGENT_COUNT_FILE_BASED: 37 -->
+- **File-based agents** (39) - Defined in `plugins/*/agents/*.md` with frontmatter <!-- AGENT_COUNT_FILE_BASED: 39 -->
 - **Role-based agents** (10) - Defined inline via Task tool with specialized prompts <!-- AGENT_COUNT_ROLE_BASED: 10 -->
 
 ---

scripts/generate-docs.js

@@ -373,20 +373,31 @@ function generateAgentNavTable(agents, plugins) {
 
 /**
  * Generate the agents count summary line for docs/reference/AGENTS.md.
+ *
+ * Uses static fallbacks when local discovery returns nothing — the agentsys
+ * monorepo no longer contains plugins/, so discovery is empty in CI. Static
+ * counts are derived from STATIC_PLUGIN_AGENT_COUNTS so they stay in sync as
+ * plugins are added.
  */
 function generateAgentCounts(agents, plugins) {
-  const fileBasedAgents = agents.length;
-  const totalAgents = fileBasedAgents + ROLE_BASED_AGENT_COUNT;
-
-  // Count plugins with agents (file-based or role-based)
-  const pluginsWithAgents = new Set();
-  for (const agent of agents) {
-    pluginsWithAgents.add(agent.plugin);
+  const totalAgents = agents.length > 0
+    ? agents.length + ROLE_BASED_AGENT_COUNT
+    : STATIC_AGENT_COUNT;
+  const totalPlugins = plugins.length > 0 ? plugins.length : STATIC_PLUGIN_COUNT;
+
+  let pluginsWithAgentsCount;
+  if (agents.length > 0) {
+    const pluginsWithAgents = new Set(agents.map(a => a.plugin));
+    pluginsWithAgents.add('audit-project'); // role-based
+    pluginsWithAgentsCount = pluginsWithAgents.size;
+  } else {
+    // Static fallback: file-based plugins (count > 0 in static map) plus
+    // audit-project (role-based, count is 0 in the map but still has agents).
+    const fileBasedPluginsWithAgents = Object.values(STATIC_PLUGIN_AGENT_COUNTS).filter(c => c > 0).length;
+    pluginsWithAgentsCount = fileBasedPluginsWithAgents + 1;
   }
-  pluginsWithAgents.add('audit-project'); // role-based
-  const pluginCount = pluginsWithAgents.size;
 
-  return `**TL;DR:** ${totalAgents} agents across ${plugins.length} plugins (${pluginCount} have agents). opus for reasoning, sonnet for patterns, haiku for execution. Each agent does one thing well. <!-- AGENT_COUNT_TOTAL: ${totalAgents} -->`;
+  return `**TL;DR:** ${totalAgents} agents across ${totalPlugins} plugins (${pluginsWithAgentsCount} have agents). opus for reasoning, sonnet for patterns, haiku for execution. Each agent does one thing well. <!-- AGENT_COUNT_TOTAL: ${totalAgents} -->`;
 }
 
 // ---------------------------------------------------------------------------

site/index.html

@@ -749,7 +749,7 @@ <h2 class="agents-skills__title anim-fade-up" id="as-title">49 Agents. 41 Skills
         </div>
 
         <!-- Skills grid -->
-        <h3 class="agents-skills__skills-title anim-fade-up" data-delay="300">41 Skills across 20 Plugins</h3>
+        <h3 class="agents-skills__skills-title anim-fade-up" data-delay="300">41 Skills across 19 Plugins</h3>
         <div class="skills-grid anim-fade-up" data-delay="350">
           <div class="skill-group">
             <span class="skill-group__label">prepare-delivery</span>

site/ux-spec.md

@@ -228,7 +228,7 @@ Done. Task to merged PR in 12 minutes.
 |------|-------|-------|
 | 1 | 20 | Plugins |
 | 2 | 49 | Agents |
-| 3 | 40 | Skills |
+| 3 | 41 | Skills |
 | 4 | 3,507 | Tests Passing |
 
 ### Styling