fix: address Gemini review feedback

- Add null check in extractPatternIds to prevent Object.values(null)
- Use Set for foundPatterns to optimize O(n) lookups to O(1)
- Export toPascalCase from benchmark.js and remove duplicate in tests

Author: avifenesh

__tests__/enhance-pattern-benchmarks.test.js

@@ -4,7 +4,8 @@ const {
   runPatternBenchmarks,
   runFixBenchmarks,
   generateReport,
-  assertThresholds
+  assertThresholds,
+  toPascalCase
 } = require('../lib/enhance/benchmark');
 const { analyzeAgent } = require('../lib/enhance/agent-analyzer');
 const { analyzePrompt } = require('../lib/enhance/prompt-analyzer');
@@ -208,10 +209,3 @@ describe('Pattern Validation Benchmarks', () => {
     });
   });
 });
-
-function toPascalCase(str) {
-  return str
-    .split('_')
-    .map(part => part.charAt(0).toUpperCase() + part.slice(1))
-    .join('');
-}

lib/enhance/benchmark.js

@@ -45,14 +45,15 @@ function runPatternBenchmarks(manifestPath, analyzers) {
     }
 
     // Extract pattern IDs from findings
-    const foundPatterns = extractPatternIds(findings);
+    const foundPatternsArray = extractPatternIds(findings);
+    const foundPatterns = new Set(foundPatternsArray);
     const expectedPatterns = new Set(expectations.expectedPatterns || []);
     const mustNotTrigger = new Set(expectations.mustNotTrigger || []);
 
     // Calculate metrics for this fixture
     const fixtureResult = {
       expected: Array.from(expectedPatterns),
-      found: foundPatterns,
+      found: foundPatternsArray,
       truePositives: [],
       falsePositives: [],
       falseNegatives: [],
@@ -61,7 +62,7 @@ function runPatternBenchmarks(manifestPath, analyzers) {
 
     // True positives: expected AND found
     for (const pattern of expectedPatterns) {
-      if (foundPatterns.includes(pattern)) {
+      if (foundPatterns.has(pattern)) {
         fixtureResult.truePositives.push(pattern);
         results.summary.truePositives++;
         updatePatternStats(results.byPattern, pattern, 'tp');
@@ -83,7 +84,7 @@ function runPatternBenchmarks(manifestPath, analyzers) {
 
     // Must-not-trigger violations
     for (const pattern of mustNotTrigger) {
-      if (foundPatterns.includes(pattern)) {
+      if (foundPatterns.has(pattern)) {
         fixtureResult.mustNotTriggerViolations.push(pattern);
       }
     }
@@ -313,7 +314,7 @@ function extractPatternIds(findings) {
     for (const f of findings) {
       if (f.patternId) ids.push(f.patternId);
     }
-  } else if (typeof findings === 'object') {
+  } else if (findings && typeof findings === 'object') {
     // Handle analyzer result objects with issue arrays
     for (const value of Object.values(findings)) {
       if (Array.isArray(value)) {
@@ -378,5 +379,6 @@ module.exports = {
   runFixBenchmarks,
   generateReport,
   assertThresholds,
-  extractPatternIds
+  extractPatternIds,
+  toPascalCase
 };