fix: address remaining Cursor review findings

Author: avifenesh

.github/workflows/mcp-release-watch.yml

@@ -54,27 +54,30 @@ jobs:
             latest_release=""
           fi
 
+          # Ignore prerelease/suffixed tags such as 2026-07-28-RC. Only final
+          # date tags can identify a published specification revision.
+          if [[ -n "$latest_release" && ! "$latest_release" =~ ^[0-9]{4}-[0-9]{2}-[0-9]{2}$ ]]; then
+            echo "Ignoring non-final MCP release/tag: $latest_release"
+            latest_release=""
+          fi
+
           if [[ -z "$latest_release" ]]; then
-            # No releases, check tags instead
-            if ! latest_release=$(gh api "repos/$MCP_REPO/tags" --jq '.[0].name // empty' 2>/dev/null); then
+            # No final release, select the newest final date tag instead of
+            # blindly accepting an RC/final-suffixed tag at index zero.
+            if ! latest_release=$(gh api "repos/$MCP_REPO/tags" --jq '[.[].name | select(test("^[0-9]{4}-[0-9]{2}-[0-9]{2}$"))][0] // empty' 2>/dev/null); then
               echo "ERROR: Failed to query MCP releases and tags"
               exit 1
             fi
           fi
 
           if [[ -z "$latest_release" ]]; then
-            echo "ERROR: MCP repository returned no releases or tags"
-            exit 1
+            echo "No final date-based MCP release found; ignoring prerelease tags"
+            echo "NEW_RELEASE=false" >> "$GITHUB_OUTPUT"
+            exit 0
           fi
 
           echo "Latest release/tag: $latest_release"
 
-          # MCP uses date-based versioning like "2025-11-25"
-          if [[ ! "$latest_release" =~ ^[0-9]{4}-[0-9]{2}-[0-9]{2}$ ]]; then
-            echo "ERROR: Unsupported MCP release format: $latest_release"
-            exit 1
-          fi
-
           if [[ "$latest_release" > "$baseline_version" ]]; then
             echo "NEW_RELEASE=true" >> "$GITHUB_OUTPUT"
             echo "NEW_VERSION=$latest_release" >> "$GITHUB_OUTPUT"

crates/agnix-core/src/file_types/detection.rs

@@ -424,7 +424,8 @@ pub fn detect_file_type(path: &Path) -> FileType {
             FileType::ClaudeOutputStyle
         }
         // Cursor project rules (.cursor/rules/**/*.md and .mdc)
-        name if (ends_with_ignore_ascii_case(name, ".md") || name.ends_with(".mdc"))
+        name if (ends_with_ignore_ascii_case(name, ".md")
+            || ends_with_ignore_ascii_case(name, ".mdc"))
             && is_under_cursor_rules(path) =>
         {
             FileType::CursorRule
@@ -930,7 +931,7 @@ mod tests {
             detect_file_type(Path::new(".cursor/rules/custom.MD")),
             FileType::CursorRule
         );
-        assert_ne!(
+        assert_eq!(
             detect_file_type(Path::new(".cursor/rules/custom.MDC")),
             FileType::CursorRule
         );

crates/agnix-core/src/rules/cursor.rs

@@ -828,10 +828,7 @@ fn validate_cursor_agent_file(
 
                 if let Some(model_value) = frontmatter_map.get(key("model")) {
                     match model_value {
-                        YamlValue::String(model)
-                            if model == "fast"
-                                || model == "inherit"
-                                || is_valid_cursor_model_id(model) => {}
+                        YamlValue::String(model) if is_valid_cursor_model_id(model) => {}
                         YamlValue::String(_) => diagnostics.push(
                             Diagnostic::error(
                                 path.to_path_buf(),
@@ -969,6 +966,8 @@ fn validate_cursor_environment_file(
         }
     };
 
+    // Cursor's VS Code JSON service treats root `$schema` as the schema-association
+    // key even though the published schema's closed property set does not declare it.
     const ALLOWED_ROOT_FIELDS: &[&str] = &[
         "$schema",
         "name",
@@ -997,7 +996,7 @@ fn validate_cursor_environment_file(
         }
     }
 
-    for field in ["name", "user", "snapshot"] {
+    for field in ["$schema", "name", "user", "snapshot"] {
         if root.get(field).is_some_and(|value| !value.is_string()) {
             diagnostics.push(
                 cursor_environment_error(
@@ -2493,6 +2492,7 @@ is_background: false
 
         for (name, content) in [
             ("unknown root field", r#"{"unknown":true}"#),
+            ("invalid schema association", r#"{"$schema":42}"#),
             ("invalid name", r#"{"name":1}"#),
             ("invalid user", r#"{"user":false}"#),
             (
@@ -2807,11 +2807,16 @@ Review the diff and suggest improvements."#;
 
     #[test]
     fn test_cur_020_mdc_rule_is_recognized() {
-        let diagnostics = validate_cursor_rule(
+        for path in [
             ".cursor/rules/typescript.mdc",
-            "---\ndescription: TypeScript rules\n---\nUse strict mode.",
-        );
-        assert!(diagnostics.iter().all(|d| d.rule != "CUR-020"));
+            ".cursor/rules/typescript.MDC",
+        ] {
+            let diagnostics = validate_cursor_rule(
+                path,
+                "---\ndescription: TypeScript rules\n---\nUse strict mode.",
+            );
+            assert!(diagnostics.iter().all(|d| d.rule != "CUR-020"));
+        }
     }
 
     #[test]

crates/agnix-rules/rules.json

@@ -7586,7 +7586,7 @@
       "fix": {
         "autofix": false
       },
-      "good_example": "{\"build\":{\"dockerfile\":\"Dockerfile\",\"context\":\"..\"},\"install\":\"npm ci\",\"start\":\"npm run dev\",\"terminals\":[{\"name\":\"app\",\"command\":\"npm run dev\"}]}",
+      "good_example": "{\"$schema\":\"https://cursor.com/schemas/environment.schema.json\",\"build\":{\"dockerfile\":\"Dockerfile\",\"context\":\"..\"},\"install\":\"npm ci\",\"start\":\"npm run dev\",\"terminals\":[{\"name\":\"app\",\"command\":\"npm run dev\"}]}",
       "bad_example": "{\"install\":42,\"terminals\":[{\"name\":\"app\"}]}"
     },
     {

knowledge-base/VALIDATION-RULES.md

@@ -1817,7 +1817,7 @@ Output-style files (`.claude/output-styles/*.md` or `~/.claude/output-styles/*.m
 
 <a id="cur-016"></a>
 ### CUR-016 [HIGH] Invalid .cursor/environment.json Schema
-**Requirement**: `.cursor/environment.json` MUST match the published schema at cursor.com/schemas/environment.schema.json. Comments are allowed, trailing commas are not, no root field is required, `build.dockerfile` is required when `build` exists, and unknown root/build fields are rejected. Terminal entries require only `command`; `name` and `description` are optional. `update` is not in the schema and is reported as renamed to `install`.
+**Requirement**: `.cursor/environment.json` MUST match the published schema at cursor.com/schemas/environment.schema.json. Comments are allowed, trailing commas are not, no root field is required, `build.dockerfile` is required when `build` exists, and unknown root/build fields are rejected except for the conventional root `$schema` association key. Terminal entries require only `command`; `name` and `description` are optional. `update` is not in the schema and is reported as renamed to `install`.
 **Detection**: Strip JSON comments, parse JSON, enforce the root/build closed-field sets, and validate setup strings, repository dependencies, ports, build fields, snapshot fields, and terminal entries
 **Fix**: Correct field types; rename `update` to `install`
 **Source**: cursor.com/docs/cloud-agent/setup

knowledge-base/rules.json

@@ -7586,7 +7586,7 @@
       "fix": {
         "autofix": false
       },
-      "good_example": "{\"build\":{\"dockerfile\":\"Dockerfile\",\"context\":\"..\"},\"install\":\"npm ci\",\"start\":\"npm run dev\",\"terminals\":[{\"name\":\"app\",\"command\":\"npm run dev\"}]}",
+      "good_example": "{\"$schema\":\"https://cursor.com/schemas/environment.schema.json\",\"build\":{\"dockerfile\":\"Dockerfile\",\"context\":\"..\"},\"install\":\"npm ci\",\"start\":\"npm run dev\",\"terminals\":[{\"name\":\"app\",\"command\":\"npm run dev\"}]}",
       "bad_example": "{\"install\":42,\"terminals\":[{\"name\":\"app\"}]}"
     },
     {

tests/ci_workflow.rs

@@ -44,3 +44,24 @@ fn ci_keeps_linux_only_quality_gates_on_ubuntu() {
         );
     }
 }
+
+#[test]
+fn mcp_release_watch_filters_prerelease_tags() {
+    let root = env!("CARGO_MANIFEST_DIR");
+    let workflow = fs::read_to_string(format!("{root}/.github/workflows/mcp-release-watch.yml"))
+        .expect("failed to read MCP release-watch workflow")
+        .replace("\r\n", "\n");
+
+    assert!(
+        workflow.contains(r#"select(test("^[0-9]{4}-[0-9]{2}-[0-9]{2}$"))"#),
+        "MCP tag fallback must select only final date-based versions"
+    );
+    assert!(
+        workflow.contains("Ignoring non-final MCP release/tag"),
+        "MCP prerelease tags must be ignored instead of failing the workflow"
+    );
+    assert!(
+        !workflow.contains("ERROR: Unsupported MCP release format"),
+        "known MCP prerelease tag shapes must not hard-fail the workflow"
+    );
+}

website/docs/rules/generated/cur-016.md

@@ -45,5 +45,5 @@ The following examples demonstrate what triggers this rule and how to fix it.
 ### Valid
 
 ```json
-{"build":{"dockerfile":"Dockerfile","context":".."},"install":"npm ci","start":"npm run dev","terminals":[{"name":"app","command":"npm run dev"}]}
+{"$schema":"https://cursor.com/schemas/environment.schema.json","build":{"dockerfile":"Dockerfile","context":".."},"install":"npm ci","start":"npm run dev","terminals":[{"name":"app","command":"npm run dev"}]}
 ```