refactor(core): narrow public API surface (#85) (#156)

* refactor(core): narrow public API surface (#85)

- Make parsers, rules, and schemas modules private
- Re-export Validator trait to maintain extensibility for custom validators

* docs: add changelog entry for API surface narrowing (#85)

* refactor(core): also make file_utils module private

Address review feedback from gemini-code-assist: file_utils is an
internal utility not used by external consumers, so it should be
private alongside parsers, rules, and schemas.

* fix: address clippy warnings after making modules private

- Remove unused pub use re-exports from parsers/mod.rs and schemas/mod.rs
- Fix SkillSchema import path to use direct module path
- Add #[allow(dead_code)] to internal modules (parsers, schemas)

The dead code warnings appeared because these modules are now private
and some items were only "used" via the public API surface. The items
are preserved for future use and internal consistency.

Author: avifenesh

CHANGELOG.md

@@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Changed
+- Narrowed agnix-core public API surface (#85)
+  - Made `parsers`, `rules`, `schemas`, and `file_utils` modules private
+  - Re-exported `Validator` trait for custom validator implementations
+  - No breaking changes for agnix-cli or external consumers using documented API
+
 ### Removed
 - Removed unused config flags `tool_names` and `required_fields` from `.agnix.toml`
   - These flags were never referenced in the codebase

crates/agnix-core/src/lib.rs

@@ -12,11 +12,11 @@
 
 pub mod config;
 pub mod diagnostics;
-pub mod file_utils;
+mod file_utils;
 pub mod fixes;
-pub mod parsers;
-pub mod rules;
-pub mod schemas;
+mod parsers;
+mod rules;
+mod schemas;
 
 use std::collections::HashMap;
 use std::path::{Path, PathBuf};
@@ -26,7 +26,7 @@ use rayon::prelude::*;
 pub use config::LintConfig;
 pub use diagnostics::{Diagnostic, DiagnosticLevel, Fix, LintError, LintResult};
 pub use fixes::{apply_fixes, FixResult};
-use rules::Validator;
+pub use rules::Validator;
 
 /// Result of validating a project, including diagnostics and metadata.
 #[derive(Debug, Clone)]

crates/agnix-core/src/parsers/mod.rs

@@ -1,8 +1,10 @@
 //! File parsers for different config formats
+//!
+//! This module is internal to agnix-core. Some items may not be used
+//! directly but are preserved for potential future use or extensibility.
+
+#![allow(dead_code)]
 
 pub mod frontmatter;
 pub mod json;
 pub mod markdown;
-
-pub use frontmatter::{parse_frontmatter, split_frontmatter, FrontmatterParts};
-pub use json::parse_json_config;

crates/agnix-core/src/rules/skill.rs

@@ -5,7 +5,7 @@ use crate::{
     diagnostics::{Diagnostic, Fix},
     parsers::frontmatter::{split_frontmatter, FrontmatterParts},
     rules::Validator,
-    schemas::SkillSchema,
+    schemas::skill::SkillSchema,
 };
 use regex::Regex;
 use serde::Deserialize;

crates/agnix-core/src/schemas/mod.rs

@@ -1,4 +1,9 @@
 //! Schema definitions for agent config files
+//!
+//! This module is internal to agnix-core. Some items may not be used
+//! directly but are preserved for potential future use or extensibility.
+
+#![allow(dead_code)]
 
 pub mod agent;
 pub mod agents_md;
@@ -10,9 +15,3 @@ pub mod mcp;
 pub mod plugin;
 pub mod prompt;
 pub mod skill;
-
-pub use agent::AgentSchema;
-pub use hooks::HooksSchema;
-pub use mcp::McpToolSchema;
-pub use plugin::PluginSchema;
-pub use skill::SkillSchema;