ci: follow-up fixes from install-action migration review [skip changelog] - #527
Merged
Conversation
- Update taiki-e/install-action SHA comments from '# v2' to '# v2.67.30' to accurately reflect the pinned version across all 11 references - Pin cargo-nextest to @0.9.128 in test and coverage jobs for reproducible builds (was unpinned, inconsistent with all other tools) - Add fallback: cargo-install to cargo-fuzz step in fuzz.yml to bypass the cargo-binstall intermediary, matching original install behavior - Add if: runner.os == 'Linux' guard to iai-callgrind-runner install step since the taiki-e manifest only supports Linux platforms - Update .github/workflows/README.md version label to v2.67.30
Contributor
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
Contributor
There was a problem hiding this comment.
Pull request overview
Follow-up CI workflow adjustments after the taiki-e/install-action migration in #526, aiming to make action-version annotations accurate and tool installs fully pinned/reliable.
Changes:
- Update
taiki-e/install-actioninline SHA comments from# v2to# v2.67.30across workflows and the workflow README. - Pin
cargo-nextestto0.9.128in CItestandcoveragejobs. - Adjust tool installation behavior/guards:
cargo-fuzzusesfallback: cargo-install, andiai-callgrind-runnerinstall is guarded to Linux.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/security.yml | Updates install-action version comment for cargo-audit step. |
| .github/workflows/release.yml | Updates install-action version comment for cross install step. |
| .github/workflows/fuzz.yml | Updates install-action version comment; adds fallback: cargo-install for cargo-fuzz. |
| .github/workflows/docs-site.yml | Updates install-action version comment for wasm-pack install step. |
| .github/workflows/ci.yml | Updates install-action version comments; pins cargo-nextest; adds Linux-only guard for iai-callgrind-runner install. |
| .github/workflows/README.md | Updates the install-action reference label to v2.67.30. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up fixes identified during review of #526.
taiki-e/install-actionSHA comments from# v2to# v2.67.30- the SHA288875ddresolves to v2.67.30, not the current v2 floating tag@0.9.128in bothtestandcoveragejobs - was the only unpinned tool, inconsistent with all othersfallback: cargo-installto skip the cargo-binstall intermediary since cargo-fuzz has no prebuilt binary in the taiki-e manifestif: runner.os == 'Linux'since the taiki-e manifest only supports Linux platforms@v2to@v2.67.30Test plan